Skip to content

Commit 2edc479

Browse files
authored
Enable 'bugprone-narrowing-conversions' clang-tidy check (learning-process#300)
1 parent 4fffc98 commit 2edc479

File tree

5 files changed

+11
-12
lines changed

5 files changed

+11
-12
lines changed

.clang-tidy

-1
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ Checks: >
1212
-bugprone-casting-through-void,
1313
-bugprone-exception-escape,
1414
-bugprone-implicit-widening-of-multiplication-result,
15-
-bugprone-narrowing-conversions,
1615
-misc-const-correctness,
1716
-misc-header-include-cycle,
1817
-misc-no-recursion,

modules/ref/most_different_neighbor_elements/func_tests/ref_tests.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ TEST(most_different_neighbor_elements, check_int32_t) {
1414
std::vector<int32_t> out(2, 0);
1515
std::vector<uint64_t> out_index(2, 0);
1616
for (size_t i = 0; i < in.size(); i++) {
17-
in[i] = 2 * i;
17+
in[i] = static_cast<int32_t>(2 * i);
1818
}
1919
in[234] = 0;
2020
in[235] = 4000;
@@ -68,7 +68,7 @@ TEST(most_different_neighbor_elements, check_double) {
6868
std::vector<double> out(2, 0);
6969
std::vector<uint64_t> out_index(2, 0);
7070
for (size_t i = 0; i < in.size(); i++) {
71-
in[i] = i;
71+
in[i] = static_cast<double>(i);
7272
}
7373
in[189] = -1000.1;
7474
in[190] = 9000.9;
@@ -177,7 +177,7 @@ TEST(most_different_neighbor_elements, check_float) {
177177
std::vector<float> out(2, 0.F);
178178
std::vector<uint64_t> out_index(2, 0);
179179
for (size_t i = 0; i < in.size(); i++) {
180-
in[i] += (i + 1.F) * 2.5F;
180+
in[i] += (static_cast<float>(i) + 1.F) * 2.5F;
181181
}
182182
in[0] = 110.001F;
183183
in[1] = -990.0025F;

modules/ref/nearest_neighbor_elements/func_tests/ref_tests.cpp

+3-3
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ TEST(nearest_neighbor_elements, check_int32_t) {
1414
std::vector<int32_t> out(2, 0);
1515
std::vector<uint64_t> out_index(2, 0);
1616
for (size_t i = 0; i < in.size(); i++) {
17-
in[i] = 2 * i;
17+
in[i] = static_cast<int32_t>(2 * i);
1818
}
1919
in[234] = 0;
2020
in[235] = 1;
@@ -68,7 +68,7 @@ TEST(nearest_neighbor_elements, check_double) {
6868
std::vector<double> out(2, 0);
6969
std::vector<uint64_t> out_index(2, 0);
7070
for (size_t i = 0; i < in.size(); i++) {
71-
in[i] = 2 * i;
71+
in[i] = static_cast<double>(2 * i);
7272
}
7373
in[189] = 0.1;
7474
in[190] = 0.9;
@@ -177,7 +177,7 @@ TEST(nearest_neighbor_elements, check_float) {
177177
std::vector<float> out(2, 0.F);
178178
std::vector<uint64_t> out_index(2, 0);
179179
for (size_t i = 0; i < in.size(); i++) {
180-
in[i] += (i + 1.F) * 2.5F;
180+
in[i] += static_cast<float>(i + 1) * 2.5F;
181181
}
182182
in[0] = 0.001F;
183183
in[1] = 0.0025F;

modules/ref/sum_values_by_rows_matrix/func_tests/ref_tests.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,7 @@ TEST(sum_values_by_rows_matrix, check_int64_t) {
140140
std::vector<uint64_t> in_index = {37, 38};
141141
std::vector<int64_t> out(37, 0);
142142
for (size_t i = 0; i < in.size(); ++i) {
143-
in[i] = (i % 38) + 1;
143+
in[i] = static_cast<int64_t>((i % 38) + 1);
144144
}
145145

146146
// Create task_data

modules/ref/vector_dot_product/func_tests/ref_tests.cpp

+4-4
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ TEST(vector_dot_product, check_int32_t) {
1515
std::vector<int32_t> in2(count_data, 1);
1616
std::vector<int32_t> out(1, 0);
1717
for (size_t i = 0; i < count_data; i++) {
18-
in1[i] = i + 1;
19-
in2[i] = i + 1;
18+
in1[i] = static_cast<int32_t>(i + 1);
19+
in2[i] = static_cast<int32_t>(i + 1);
2020
}
2121

2222
// Create task_data
@@ -140,8 +140,8 @@ TEST(vector_dot_product, check_int64_t) {
140140
std::vector<int64_t> in2(count_data, 1);
141141
std::vector<int64_t> out(1, 0);
142142
for (uint64_t i = 0; i < count_data; i++) {
143-
in1[i] = i + 1;
144-
in2[i] = (i + 1) * (i + 1);
143+
in1[i] = static_cast<int64_t>(i + 1);
144+
in2[i] = static_cast<int64_t>((i + 1) * (i + 1));
145145
}
146146

147147
// Create task_data

0 commit comments

Comments
 (0)