Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Either remove short_name_for_model_object or allow for full name registering of models #116

Open
kyleclo opened this issue Feb 7, 2023 · 1 comment

Comments

@kyleclo
Copy link

kyleclo commented Feb 7, 2023

Took a while to debug why google/t5-v1_1-small wasn't working even though it's registered in models/__init__.py. It's not obvious how the shortened name is particularly beneficial whereas the cost is that it's hard to know the right flags for model names to pass to catwalk.

Recommend either removing this shortener or at least always supporting the full name of the model.

Haven't tested this for Tasks, but I imagine similar type of issue.

@dirkgr
Copy link
Member

dirkgr commented Feb 7, 2023

How would you feel if there was a command that prints out all available model names?

Or if the error message contained that list?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants