Stop mixing body and parameters in UpdateByQuery (elastic#1702)

pquentin · web-flow · commit 40e16323289f · 2024-02-08T10:45:41.000+04:00
diff --git a/elasticsearch_dsl/update_by_query.py b/elasticsearch_dsl/update_by_query.py
@@ -154,6 +154,6 @@ def execute(self):
 
         self._response = self._response_class(
             self,
-            es.update_by_query(index=self._index, body=self.to_dict(), **self._params),
+            es.update_by_query(index=self._index, **self.to_dict(), **self._params),
         )
         return self._response
diff --git a/tests/test_update_by_query.py b/tests/test_update_by_query.py
@@ -141,9 +141,7 @@ def test_params_being_passed_to_search(mock_client):
     ubq = ubq.params(routing="42")
     ubq.execute()
 
-    mock_client.update_by_query.assert_called_once_with(
-        index=None, body={}, routing="42"
-    )
+    mock_client.update_by_query.assert_called_once_with(index=None, routing="42")
 
 
 def test_overwrite_script():

Original file line number	Diff line number	Diff line change
`@@ -154,6 +154,6 @@ def execute(self):`
`154`	`154`
`155`	`155`	`self._response = self._response_class(`
`156`	`156`	`self,`
`157`		`- es.update_by_query(index=self._index, body=self.to_dict(), **self._params),`
	`157`	`+ es.update_by_query(index=self._index, self.to_dict(), self._params),`
`158`	`158`	`)`
`159`	`159`	`return self._response`