clean up

Author: alexpineda

.eslintrc.js

@@ -88,7 +88,10 @@ module.exports = {
         // revisit these
         "@typescript-eslint/no-unsafe-call": "off",
         "@typescript-eslint/no-unsafe-member-access": "off",
-        "t@typescript-eslint/consistent-type-definitions": "off",
+        "@typescript-eslint/consistent-type-definitions": "off",
+
+        // until it stops fighting with itself
+        "@typescript-eslint/no-inferrable-types": "off",
     },
     globals: {
         __static: true,

.vscode/launch.json

@@ -1,27 +1,37 @@
 {
-  // Use IntelliSense to learn about possible attributes.
-  // Hover to view descriptions of existing attributes.
-  // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
-  "version": "0.2.0",
-  "configurations": [
-    {
-      "name": "Debug Jest Tests",
-      "type": "node",
-      "request": "launch",
-      "runtimeArgs": [
-        "--inspect-brk",
-        "${workspaceRoot}/node_modules/jest/bin/jest",
-        "--runInBand",
-        "--no-cache"
-      ],
-      "console": "integratedTerminal",
-      "internalConsoleOptions": "neverOpen",
-      "smartStep": true,
-      "skipFiles": ["<node_internals>/**", "node_modules/**"],
-      "autoAttachChildProcesses": true,
-      "sourceMaps": true,
-      "disableOptimisticBPs": "true",
-      "outFiles": ["${workspaceFolder}/**/*.js", "!**/node_modules/**"]
-    }
-  ]
+    // Use IntelliSense to learn about possible attributes.
+    // Hover to view descriptions of existing attributes.
+    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
+    "version": "0.2.0",
+    "configurations": [
+        {
+            "name": "Debug Jest Tests",
+            "type": "node",
+            "request": "launch",
+            "runtimeArgs": [
+                "--inspect-brk",
+                "${workspaceRoot}/node_modules/jest/bin/jest",
+                "--runInBand",
+                "--no-cache"
+            ],
+            "console": "integratedTerminal",
+            "internalConsoleOptions": "neverOpen",
+            "smartStep": true,
+            "skipFiles": ["<node_internals>/**", "node_modules/**"],
+            "autoAttachChildProcesses": true,
+            "sourceMaps": true,
+            "disableOptimisticBPs": "true",
+            "outFiles": ["${workspaceFolder}/**/*.js", "!**/node_modules/**"]
+        },
+        {
+            "type": "node-terminal",
+            "request": "launch",
+            "name": "Run tsc verbosely",
+            "command": "yarn tsc -b --verbose --noEmit",
+            "presentation": {
+                "reveal": "always",
+                "panel": "new"
+            }
+        }
+    ]
 }

src/common/bwdat/dat.ts

@@ -6,11 +6,11 @@ export interface FormatType {
     size: number;
     names?: string[];
     name?: string;
-    get?: ( i: number ) => any;
+    get?: ( i: number ) => unknown;
     range?: () => number[];
 }
 
-export class DAT<Type> {
+export class DAT<Type extends object> {
     private readonly readFile: ReadFile;
     private initialized?: Promise<string[]>;
     stats: string[] = [];
@@ -118,10 +118,10 @@ export class DAT<Type> {
 
             return values.reduce<Type>( ( memo: Type, { name, value } ) => {
                 return { ...memo, [name as keyof Type]: value } as Type;
-            }, {} );
+            }, {} as unknown as Type );
         } );
 
-        return ( this.entries = await this.post( entries ) );
+        return ( this.entries = this.post( entries ) );
     }
 
     protected post( entries: Type[] ) {

src/common/bwdat/parse-lo.ts

@@ -1,7 +1,6 @@
-import { Vector2 } from "three";
 import range from "../utils/range";
 
-export type LoDAT = Vector2[][];
+export type LoDAT = number[][][];
 
 export const parseLo = ( buf: Buffer ): LoDAT => {
     const frames = buf.readUInt32LE( 0 );
@@ -10,7 +9,7 @@ export const parseLo = ( buf: Buffer ): LoDAT => {
     const frameData = range( 0, frames ).map( ( frame ) => {
         let offset = buf.readUInt32LE( 8 + 4 * frame );
         return range( 0, overlays ).map( () => {
-            const coords = new Vector2( buf.readInt8( offset ), buf.readInt8( offset + 1 ) );
+            const coords = [buf.readInt8( offset ), buf.readInt8( offset + 1 )];
             offset = offset + 2;
             return coords;
         } );

src/common/macros/field-utilities.ts

@@ -94,7 +94,7 @@ export const isValidTypeOfField = ( type: string ): type is TypeOfField => {
 
 export type TypeOfField = "boolean" | "number" | "string" | "vector";
 
-export const getTypeOfField = ( field?: FieldDefinition ): TypeOfField | null => {
+export const getTypeOfField = ( field?: FieldDefinition | null ): TypeOfField | null => {
     if ( !field ) {
         return null;
     }

src/common/macros/sanitize-macros.ts

@@ -8,7 +8,7 @@ import {
     TargetedPath,
 } from "common/types";
 import { withErrorMessage } from "common/utils/with-error-message";
-import { FieldDefinition, Operator } from "../types/mutations";
+import { FieldDefinition, Operator } from "../types/fields";
 import {
     getAppFieldDefinition,
     SettingsAndPluginsMeta,
@@ -94,7 +94,7 @@ const optionExists = ( options: Required<FieldDefinition>["options"], value: str
 const patchValue = ( action: MacroAction | MacroCondition, field: FieldDefinition ) => {
     if (
         action.value === undefined ||
-        ( field.options && !optionExists( field.options, action.value ) )
+        ( field.options && !optionExists( field.options, action.value as string ) )
     ) {
         action.value = field.value;
     }