Skip to content

Commit 6b7e62b

Browse files
committed
Fix upload_lots for 8.4.0
This test is hanging on Linux with the 8.4.0 update. My poor understanding is that `perform()` should not be used with `curl_multi_socket_action` (that is, it should only use `perform` or `action`, not both). Removing this seems to fix things. Note that there were some other hang-related changes in the 8.4.0 release. I bisected the hang to curl/curl#11939, which then uncovered some curl tests that were hanging in curl/curl#12033. That then spawned off two more changes to fix the hangs (both of which are also in 8.4.0). However, this upload_lots was still failing. I think this is likely due to an incorrect use of the API poorly interacting with the timer changes in 8.4.0.
1 parent 4dea23f commit 6b7e62b

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

tests/multi.rs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -140,7 +140,6 @@ fn upload_lots() {
140140

141141
let e = t!(m.add(h));
142142

143-
assert!(t!(m.perform()) > 0);
144143
let mut next_token = 1;
145144
let mut token_map = HashMap::new();
146145
let mut cur_timeout = None;

0 commit comments

Comments
 (0)