feat added localDependencies #178
Open
+249
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thefeymesaleng
changed the title
Collaborator
|
Hey @thefeymesaleng |
commit: |
Collaborator
|
Hey @thefeymesaleng, Can you please add some tests to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that this repository does not currently support
localDependenciesdue to challenges with the isoworker implementation. Last year, I submitted a PR to vueuse for useWebWorkerFn( a feature that is based on this repo) to addlocalDependencies. To align with vueuse's preference for a dependency-free core package, I avoided using isoworker, and use a simpler implementation. While we already solve the localDeps problems, I think this implementation should work the same for this repo. So I hope @alewin can review this PR and your user can enjoy localDeps. Cheers.This PR should address the following issues: #112, #105.
PS
Sorry for the formatting