Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typographic errors in samples for ancient languages (low priority) #550

Closed
tytyvillus opened this issue Feb 5, 2024 · 5 comments · Fixed by #401
Closed

Typographic errors in samples for ancient languages (low priority) #550

tytyvillus opened this issue Feb 5, 2024 · 5 comments · Fixed by #401

Comments

@tytyvillus
Copy link
Contributor

tytyvillus commented Feb 5, 2024

Small typographic errors in the Latin and Greek texts in Sample.pdf (low priority).

Current Correct Errors
ὦ κοινὸν αὐτάδελφον Ἰσμήνης κάρα,
ἆῤ οἶσθ᾽ ὅ τι Ζεὺς τῶν ἀπ᾽ Οἰδίπου κακῶν
ὁποῖον οὐχὶ νῷν ἔτι ζσαιν τελεῖ;
Ὦ κοινὸν αὐτάδελφον Ἰσμήνης κάρα,
ἆρ’ οἶσθ’ ὅ τι Ζεὺς τῶν ἀπ’ Οἰδίπου κακῶν
ὁποῖον οὐχὶ νῷν ἔτι ζώσαιν τελεῖ;
Missing omega in zosain;
apostrophes strange.
appelantur appellantur Double ell.
āēīōū āēīōūȳ Long y exists in Latin.

EDIT: Corrected apel... to appell... — my mistake.

@alerque
Copy link
Owner

alerque commented Sep 24, 2024

Thanks for reporting this. I'll definitely fix this, but probably not in the current Libre Office based sample page. Updating that creates a huge binary artifact churn in the repo and it is very difficult to keep in sync prior to a release.

I'm going to redo the samples using SILE (and perhaps FontProof, see #401) but I'll keep this open to make sure your corrected text gets used in place of those sample texts.

@alerque
Copy link
Owner

alerque commented Sep 25, 2024

I couldn't find your second correction, but it seems you have it with one ‘p’ in both your current/correct columns. A little Googling suggests the current double ‘pp’ is correct — but of course I've corrected the double ‘ll’. Let me know if that's not right. The sample page typesetting refined quite a bit from the LibreOffice based version but the gist of it is the same idea for now.

The changes you suggested are in 544eb7e.

@alerque
Copy link
Owner

alerque commented Sep 25, 2024

Since the sample PDF isn't building in CI and hence isn't visible yet for review, here is what the relevant bits to this issue look like now:

image

@tytyvillus
Copy link
Contributor Author

  • The single "p" is 100% a typo on my part, I was evidently too focussed on the "l"s. The correct version is indeed appellantur.

  • The sample text you've shown looks good — the only thing I cannot verify is whether the apostrophes are the correct Unicode character.

@alerque
Copy link
Owner

alerque commented Sep 25, 2024

You should be able to review the exact Unicode input in 544eb7e, which is mostly a copy-paste from your table above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants