Skip to content

Commit 75a69b4

Browse files
committed
fix: change credit amount type from Decimal to int
1 parent ac747b7 commit 75a69b4

File tree

4 files changed

+8
-8
lines changed

4 files changed

+8
-8
lines changed

deployment/migrations/versions/0035_a1b2c3d4e5f6_add_credit_balances_table.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ def upgrade() -> None:
2323
'credit_balances',
2424
sa.Column('id', sa.BigInteger(), autoincrement=True),
2525
sa.Column('address', sa.String(), nullable=False),
26-
sa.Column('amount', sa.DECIMAL(), nullable=False),
26+
sa.Column('amount', sa.BigInteger(), nullable=False),
2727
sa.Column('ratio', sa.DECIMAL(), nullable=True),
2828
sa.Column('tx_hash', sa.String(), nullable=True),
2929
sa.Column('token', sa.String(), nullable=True),

src/aleph/db/accessors/balances.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,7 @@ def get_updated_balance_accounts(session: DbSession, last_update: dt.datetime):
189189
return (session.execute(select_stmt)).scalars().all()
190190

191191

192-
def get_credit_balance(session: DbSession, address: str) -> Decimal:
192+
def get_credit_balance(session: DbSession, address: str) -> int:
193193
now = utc_now()
194194

195195
# Sum all non-expired credit balances for the address
@@ -203,7 +203,7 @@ def get_credit_balance(session: DbSession, address: str) -> Decimal:
203203
)
204204
).scalar()
205205

206-
return result if result is not None else Decimal(0)
206+
return result if result is not None else 0
207207

208208

209209
def get_credit_balances(
@@ -288,7 +288,7 @@ def update_credit_balances(
288288
csv_rows = []
289289
for index, credit_entry in enumerate(credits_list):
290290
address = credit_entry["address"]
291-
amount = Decimal(credit_entry["amount"]) # Cast from string to Decimal
291+
amount = int(credit_entry["amount"]) # Cast to integer
292292
ratio = Decimal(credit_entry["ratio"])
293293
tx_hash = credit_entry["tx_hash"]
294294
provider = credit_entry["provider"]
@@ -354,7 +354,7 @@ def update_credit_balances_airdrop(
354354
csv_rows = []
355355
for index, credit_entry in enumerate(credits_list):
356356
address = credit_entry["address"]
357-
amount = Decimal(credit_entry["amount"])
357+
amount = int(credit_entry["amount"]) # Cast to integer
358358
origin = credit_entry.get("origin", "")
359359
expiration_timestamp = credit_entry.get("expiration", 0)
360360

src/aleph/db/models/balances.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ class AlephCreditBalanceDb(Base):
4848
id: int = Column(BigInteger, autoincrement=True)
4949

5050
address: str = Column(String, nullable=False, index=True)
51-
amount: Decimal = Column(DECIMAL, nullable=False)
51+
amount: int = Column(BigInteger, nullable=False)
5252
ratio: Optional[Decimal] = Column(DECIMAL, nullable=True)
5353
tx_hash: Optional[str] = Column(String, nullable=True)
5454
token: Optional[str] = Column(String, nullable=True)

src/aleph/schemas/api/accounts.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class GetAccountBalanceResponse(BaseModel):
3030

3131
class GetAccountCreditBalanceResponse(BaseModel):
3232
address: str
33-
credits: FloatDecimal
33+
credits: int
3434

3535

3636
class GetAccountFilesQueryParams(BaseModel):
@@ -96,7 +96,7 @@ class AddressCreditBalanceResponse(BaseModel):
9696
model_config = ConfigDict(from_attributes=True)
9797

9898
address: str
99-
credits: FloatDecimal
99+
credits: int
100100

101101

102102
class GetAccountFilesResponseItem(BaseModel):

0 commit comments

Comments
 (0)