mod: remove unused code: ping, instance wait_for_init

Author: olethanh

src/aleph/vm/controllers/firecracker/instance.py

@@ -21,13 +21,7 @@
 from aleph.vm.hypervisors.firecracker.microvm import setfacl
 from aleph.vm.network.interfaces import TapInterface
 from aleph.vm.storage import create_devmapper, create_volume_file
-from aleph.vm.utils import (
-    HostNotFoundError,
-    NotEnoughDiskSpaceError,
-    check_disk_space,
-    ping,
-    run_in_subprocess,
-)
+from aleph.vm.utils import NotEnoughDiskSpaceError, check_disk_space, run_in_subprocess
 
 from .executable import (
     AlephFirecrackerExecutable,
@@ -120,30 +114,6 @@ async def setup(self):
             ),
         )
 
-    async def wait_for_init(self) -> None:
-        """Wait for the init process of the instance to be ready."""
-        assert self.enable_networking and self.tap_interface, f"Network not enabled for VM {self.vm_id}"
-
-        ip = self.get_ip()
-        if not ip:
-            msg = "Host IP not available"
-            raise ValueError(msg)
-
-        ip = ip.split("/", 1)[0]
-
-        attempts = 30
-        timeout_seconds = 2
-
-        for attempt in range(attempts):
-            try:
-                await ping(ip, packets=1, timeout=timeout_seconds)
-                return
-            except HostNotFoundError:
-                if attempt < (attempts - 1):
-                    continue
-                else:
-                    raise
-
     async def create_snapshot(self) -> CompressedDiskVolumeSnapshot:
         """Create a VM snapshot"""
         volume_path = await create_volume_file(self.resources.message_content.rootfs, self.resources.namespace)

src/aleph/vm/controllers/qemu/instance.py

@@ -31,7 +31,7 @@
 from aleph.vm.network.interfaces import TapInterface
 from aleph.vm.resources import HostGPU
 from aleph.vm.storage import get_rootfs_base_path
-from aleph.vm.utils import HostNotFoundError, ping, run_in_subprocess
+from aleph.vm.utils import run_in_subprocess
 
 logger = logging.getLogger(__name__)
 
@@ -231,36 +231,12 @@ async def start(self):
         # Start via systemd not here
         raise NotImplementedError()
 
-    async def wait_for_init(self) -> None:
-        """Wait for the init process of the instance to be ready."""
-        assert self.enable_networking and self.tap_interface, f"Network not enabled for VM {self.vm_id}"
-
-        ip = self.get_ip()
-        if not ip:
-            msg = "Host IP not available"
-            raise ValueError(msg)
-        ip = ip.split("/", 1)[0]
-
-        attempts = 30
-        timeout_seconds = 2
-
-        for attempt in range(attempts):
-            try:
-                await ping(ip, packets=1, timeout=timeout_seconds)
-                return
-            except HostNotFoundError:
-                if attempt < (attempts - 1):
-                    continue
-                else:
-                    raise
-
     async def start_guest_api(self):
         pass
 
     async def stop_guest_api(self):
         pass
 
-
     async def teardown(self):
         if self.enable_networking:
             teardown_nftables_for_vm(self.vm_id)

src/aleph/vm/utils/__init__.py

@@ -177,17 +177,6 @@ class HostNotFoundError(Exception):
     pass
 
 
-async def ping(host: str, packets: int, timeout: int):
-    """
-    Waits for a host to respond to a ping request.
-    """
-
-    try:
-        await run_in_subprocess(["ping", "-c", str(packets), "-W", str(timeout), host], check=True)
-    except subprocess.CalledProcessError as err:
-        raise HostNotFoundError() from err
-
-
 async def is_pinging(host: str, packets: int, timeout: int) -> bool:
     """
     Try to ping an ip, return true if host respond, fale otherwise