fix: get_message_error now handle removing status and return the reason field

Author: 1yam

src/aleph/sdk/client/http.py

@@ -465,6 +465,8 @@ async def get_message_error(
             raise RemovedMessageError(
                 f"The requested message {message_raw['item_hash']} has been removed by {', '.join(message_raw['reason'])}"
             )
+        if message_raw["status"] == "removing":
+            return {"reason": message_raw["reason"]}
         if message_raw["status"] != "rejected":
             return None
         return {

tests/unit/conftest.py

@@ -68,6 +68,13 @@ def rejected_message():
         return json.load(f)
 
 
+@pytest.fixture
+def removing_message():
+    message_path = Path(__file__).parent / "removing_message.json"
+    with open(message_path) as f:
+        return json.load(f)
+
+
 @pytest.fixture
 def aleph_messages() -> List[AlephMessage]:
     return [

tests/unit/removing_message.json

@@ -0,0 +1,35 @@
+{
+  "status": "removing",
+  "item_hash": "8315e613eae0651f698b5cdd17ae935597620bdba280d2154bed347d088072a1",
+  "reception_time": "2025-08-30T02:18:59.708600Z",
+  "message": {
+    "sender": "0x759962fB336f88a18Fe098cf3C82e51e5131ca9A",
+    "chain": "ETH",
+    "signature": "0x1caa8a64723acbd80ef321fe0de8a355b2727dad000e49d5913d0d17eb0732d64f791f8126c385c0fb30ae47f027ccb4b469427d68f25d0e010b821821b0c25b1c",
+    "type": "STORE",
+    "item_content": "{\"address\":\"0x759962fB336f88a18Fe098cf3C82e51e5131ca9A\",\"time\":1756520339.1264179,\"item_type\":\"ipfs\",\"item_hash\":\"QmVQKFq7HsEREuns2GkFHGimGppFQeFokqyzZpj94Tx35r\"}",
+    "item_type": "inline",
+    "item_hash": "8315e613eae0651f698b5cdd17ae935597620bdba280d2154bed347d088072a1",
+    "time": 1756520339.12647,
+    "channel": "ALEPH-CLOUDSOLUTIONS",
+    "content": {
+      "address": "0x759962fB336f88a18Fe098cf3C82e51e5131ca9A",
+      "time": 1756520339.12642,
+      "item_type": "ipfs",
+      "item_hash": "QmVQKFq7HsEREuns2GkFHGimGppFQeFokqyzZpj94Tx35r",
+      "size": null,
+      "content_type": null,
+      "ref": null,
+      "metadata": null
+    },
+    "confirmed": true,
+    "confirmations": [
+      {
+        "chain": "ETH",
+        "height": 23251108,
+        "hash": "0xc91a41b40c1294280983c4d76f9d7496190bace8414b83fd651dc1710e1452e3"
+      }
+    ]
+  },
+  "reason": "balance_insufficient"
+}

tests/unit/services/test_pricing.py

@@ -68,8 +68,6 @@ async def test_get_pricing_aggregate(mock_client):
     storage_price = storage_entity.price["storage"]
     assert isinstance(storage_price, Price)  # Add type assertion for mypy
     assert storage_price.holding == Decimal("0.333333333")
-    assert storage_entity.price["storage"].holding == Decimal("0.333333333")
-
     # Check program entity has correct compute unit details
     program_entity = result[PricingEntity.PROGRAM]
     assert isinstance(program_entity, PricingPerEntity)

tests/unit/test_asynchronous_get.py

@@ -86,7 +86,7 @@ async def test_get_forgotten_message():
 
 
 @pytest.mark.asyncio
-async def test_get_message_error(rejected_message):
+async def test_get_message_error_rejected(rejected_message):
     mock_session = make_mock_get_session(rejected_message)
     async with mock_session as session:
         error = await session.get_message_error(rejected_message["item_hash"])
@@ -95,5 +95,14 @@ async def test_get_message_error(rejected_message):
         assert error["details"] == rejected_message["details"]
 
 
+@pytest.mark.asyncio
+async def test_get_message_error_removing(removing_message):
+    mock_session = make_mock_get_session(removing_message)
+    async with mock_session as session:
+        error = await session.get_message_error(removing_message["item_hash"])
+        assert error
+        assert error["reason"] == removing_message["reason"]
+
+
 if __name__ == "__main __":
     unittest.main()