Small cleanups

Author: kassens

src/rule-generated-flow-types.js

@@ -28,22 +28,20 @@ function getOptions(optionValue) {
   return DEFAULT_FLOW_TYPES_OPTIONS;
 }
 
+function getTypeImportName(node) {
+  return (node.specifiers[0].local || node.specifiers[0].imported).name;
+}
+
 function genImportFixRange(type, imports, requires) {
   const typeImports = imports.filter(node => node.importKind === 'type');
   const alreadyHasImport = typeImports.some(node =>
     node.specifiers.some(
       specifier => (specifier.imported || specifier.local).name === type
     )
   );
-
   if (alreadyHasImport) {
     return null;
   }
-
-  function getTypeImportName(node) {
-    return (node.specifiers[0].local || node.specifiers[0].imported).name;
-  }
-
   if (typeImports.length > 0) {
     let precedingImportIndex = 0;
     while (
@@ -52,18 +50,14 @@ function genImportFixRange(type, imports, requires) {
     ) {
       precedingImportIndex++;
     }
-
     return typeImports[precedingImportIndex].range;
   }
-
   if (imports.length > 0) {
     return imports[imports.length - 1].range;
   }
-
   if (requires.length > 0) {
     return requires[requires.length - 1].range;
   }
-
   // start of file
   return [0, 0];
 }

src/rule-unused-fields.js

@@ -168,12 +168,11 @@ function rule(context) {
     MemberExpression: visitMemberExpression,
     OptionalMemberExpression: visitMemberExpression,
     ObjectPattern(node) {
-      node.properties
-        .filter(node => node.type === 'Property')
-        .filter(node => !node.computed)
-        .forEach(node => {
+      node.properties.forEach(node => {
+        if (node.type === 'Property' && !node.computed) {
           foundMemberAccesses[node.key.name] = true;
-        });
+        }
+      });
     },
     MethodDefinition(node) {
       currentMethod.unshift(node.key.name);