Skip to content

Commit a4fa6f2

Browse files
committed
Release v2.5.5
1 parent ddc2807 commit a4fa6f2

26 files changed

+122
-42
lines changed

README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Rollbar.js
22

3-
[![Build Status](https://api.travis-ci.org/rollbar/rollbar.js.png?branch=v2.5.4)](https://travis-ci.org/rollbar/rollbar.js)
3+
[![Build Status](https://api.travis-ci.org/rollbar/rollbar.js.png?branch=v2.5.5)](https://travis-ci.org/rollbar/rollbar.js)
44
[![Code Quality: Javascript](https://img.shields.io/lgtm/grade/javascript/g/rollbar/rollbar.js.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/rollbar/rollbar.js/context:javascript)
55
[![Total Alerts](https://img.shields.io/lgtm/alerts/g/rollbar/rollbar.js.svg?logo=lgtm&logoWidth=18)](https://lgtm.com/projects/g/rollbar/rollbar.js/alerts)
66

dist/rollbar.js

+24-4
Original file line numberDiff line numberDiff line change
@@ -482,7 +482,7 @@
482482
/* global __DEFAULT_ENDPOINT__:false */
483483

484484
var defaultOptions = {
485-
version: ("2.5.4"),
485+
version: ("2.5.5"),
486486
scrubFields: (["pw","pass","passwd","password","secret","confirm_password","confirmPassword","password_confirmation","passwordConfirmation","access_token","accessToken","secret_key","secretKey","secretToken","cc-number","card number","cardnumber","cardnum","ccnum","ccnumber","cc num","creditcardnumber","credit card number","newcreditcardnumber","new credit card","creditcardno","credit card no","card#","card #","cc-csc","cvc2","cvv2","ccv2","security code","card verification","name on credit card","name on card","nameoncard","cardholder","card holder","name des karteninhabers","card type","cardtype","cc type","cctype","payment type","expiration date","expirationdate","expdate","cc-exp"]),
487487
logLevel: ("debug"),
488488
reportLevel: ("debug"),
@@ -934,7 +934,8 @@
934934
* @returns true if e is an error
935935
*/
936936
function isError(e) {
937-
return isType(e, 'error');
937+
// Detect both Error and Firefox Exception type
938+
return isType(e, 'error') || isType(e, 'exception');
938939
}
939940

940941
function traverse(obj, func, seen) {
@@ -1204,6 +1205,7 @@
12041205
break;
12051206
case 'error':
12061207
case 'domexception':
1208+
case 'exception': // Firefox Exception type
12071209
err ? extraArgs.push(arg) : err = arg;
12081210
break;
12091211
case 'object':
@@ -3400,7 +3402,7 @@
34003402

34013403
var method = 'GET';
34023404
var url = _.formatUrl(options);
3403-
_makeRequest(accessToken, url, method, null, callback, requestFactory);
3405+
_makeZoneRequest(accessToken, url, method, null, callback, requestFactory);
34043406
}
34053407

34063408
function post(accessToken, options, payload, callback, requestFactory) {
@@ -3420,7 +3422,25 @@
34203422
var writeData = stringifyResult.value;
34213423
var method = 'POST';
34223424
var url = _.formatUrl(options);
3423-
_makeRequest(accessToken, url, method, writeData, callback, requestFactory);
3425+
_makeZoneRequest(accessToken, url, method, writeData, callback, requestFactory);
3426+
}
3427+
3428+
// Wraps _makeRequest and if Angular 2+ Zone.js is detected, changes scope
3429+
// so Angular change detection isn't triggered on each API call.
3430+
// This is the equivalent of runOutsideAngular().
3431+
//
3432+
function _makeZoneRequest(accessToken, url, method, data, callback, requestFactory) {
3433+
var gWindow = ((typeof window != 'undefined') && window) || ((typeof self != 'undefined') && self);
3434+
var currentZone = gWindow && gWindow.Zone && gWindow.Zone.current;
3435+
3436+
if (currentZone && currentZone._name === 'angular') {
3437+
var rootZone = currentZone._parent;
3438+
rootZone.run(function () {
3439+
_makeRequest(accessToken, url, method, data, callback, requestFactory);
3440+
});
3441+
} else {
3442+
_makeRequest(accessToken, url, method, data, callback, requestFactory);
3443+
}
34243444
}
34253445

34263446
function _makeRequest(accessToken, url, method, data, callback, requestFactory) {

dist/rollbar.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/rollbar.min.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/rollbar.min.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/rollbar.named-amd.js

+24-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/rollbar.named-amd.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/rollbar.named-amd.min.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/rollbar.named-amd.min.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/rollbar.noconflict.umd.js

+24-4
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/rollbar.noconflict.umd.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/rollbar.noconflict.umd.min.js

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/rollbar.noconflict.umd.min.js.map

+1-1
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)