Merge pull request #2 from Elemigrante/linters

fix: find and fix problems with ESLint and Stylelint via Lefthook

Author: alec-c4

rails-bootstrap/.eslintrc.js

@@ -11,5 +11,15 @@ module.exports = {
     sourceType: 'module',
   },
   plugins: ['@typescript-eslint'],
-  rules: {},
+  rules: {
+    "no-console": "off",
+    "no-restricted-syntax": [
+      "error",
+      {
+        "selector": "CallExpression[callee.object.name='console']"
+          + "[callee.property.name!=/^(log|warn|error|info|trace)$/]",
+        "message": "Unexpected property on console object was called"
+      }
+    ]
+  },
 };

rails-bootstrap/app/frontend/packs/application.js

@@ -7,12 +7,12 @@ import LocalTime from "local-time";
 import "../channels";
 
 import "bootstrap";
-import "@fortawesome/fontawesome-free/css/all";
+import "@fortawesome/fontawesome-free/css/all.css";
+
+import "../controllers"
 
 Rails.start();
 ActiveStorage.start();
 LocalTime.start();
 
-import "../controllers"
-
-// require.context('../images', true);
+// require.context('../images', true);

rails-bootstrap/app/frontend/stylesheets/custom.scss

@@ -26,11 +26,11 @@
   border-radius: 50%;
   -moz-background-clip: padding-box;
   -webkit-background-clip: padding-box;
-  background-clip: padding-box;
   background: indianred;
+  background-clip: padding-box;
   content: '';
   display: inline-block;
   height: 8px;
   width: 8px;
   margin-right: 6px;
-}
+}

rails-bootstrap/babel.config.js

@@ -1,17 +1,18 @@
+// eslint-disable-next-line func-names
 module.exports = function (api) {
-  var validEnv = ['development', 'test', 'production'];
-  var currentEnv = api.env();
-  var isDevelopmentEnv = api.env('development');
-  var isProductionEnv = api.env('production');
-  var isTestEnv = api.env('test');
+  const validEnv = ['development', 'test', 'production'];
+  const currentEnv = api.env();
+  const isDevelopmentEnv = api.env('development');
+  const isProductionEnv = api.env('production');
+  const isTestEnv = api.env('test');
 
   if (!validEnv.includes(currentEnv)) {
     throw new Error(
-      'Please specify a valid `NODE_ENV` or ' +
-        '`BABEL_ENV` environment variables. Valid values are "development", ' +
-        '"test", and "production". Instead, received: ' +
-        JSON.stringify(currentEnv) +
-        '.'
+      `${
+        'Please specify a valid `NODE_ENV` or '
+        + '`BABEL_ENV` environment variables. Valid values are "development", '
+        + '"test", and "production". Instead, received: '
+      }${JSON.stringify(currentEnv)}.`,
     );
   }
 

rails-bootstrap/config/webpack/environment.js

@@ -13,7 +13,9 @@ options.implementation = require('sass')
 function hotfixPostcssLoaderConfig(subloader) {
   const subloaderName = subloader.loader
   if (subloaderName === 'postcss-loader') {
+    // eslint-disable-next-line no-param-reassign
     subloader.options.postcssOptions = subloader.options.config
+    // eslint-disable-next-line no-param-reassign
     delete subloader.options.config
   }
 }
@@ -23,4 +25,4 @@ environment.loaders.keys().forEach(loaderName => {
   loader.use.forEach(hotfixPostcssLoaderConfig)
 })
 
-module.exports = environment
+module.exports = environment