Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending a superclass means subclasses won't get job stats #21

Open
henrik opened this issue Mar 26, 2015 · 2 comments
Open

Extending a superclass means subclasses won't get job stats #21

henrik opened this issue Mar 26, 2015 · 2 comments

Comments

@henrik
Copy link

henrik commented Mar 26, 2015

I've done this as a workaround in my BaseJob superclass:

# JobStats is implemented in such a way that we can't just extend a superclass:
# https://github.com/alanpeabody/resque-job-stats/blob/master/lib/resque/plugins/job_stats.rb#L19-L21
def self.inherited(subclass)
  subclass.extend Resque::Plugins::JobStats
end

Not expecting this to be fixed since the lib appears not to be maintained anymore, but perhaps this helps someone else.

@alanpeabody
Copy link
Owner

Yup, sorry. I don't and have not used Resque in a long time. I would be interested in finding a new maintainer though.

@henrik
Copy link
Author

henrik commented Mar 29, 2015

No worries, I've been there :) Thanks for stating it explicitly! Don't see myself maintaining this lib either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants