Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How feasible is it to make this into an installable plugin that works on vanilla XBMC #8

Open
johnhamelink opened this issue Sep 27, 2011 · 7 comments

Comments

@johnhamelink
Copy link

Hi there,

I was looking through the internet for a plugin for XBMC that would allow me to play music via spotify. This plugin seems to be the only thing out there!

The problem is, I'm not too keen on the idea of recompiling XBMC in order to get this functionality, so I'm wondering how feasible it would be to make a true plugin for spotify which would allow for use on a vanilla copy of XBMC, either using this code, or by writing my own?

Also, what were your reasons for editing XBMC's code? Could some of the code be worked into the official XBMC codebase?

Thanks,
John :)

@akezeke
Copy link
Owner

akezeke commented Sep 27, 2011

Hi John,

The problem is that you cant do a plugin that integrates anything into XBMC
the way I do it now, also any plugin must be written in python which is fast
enough for small scripts but will not be sufficient for a spotify plugin.

I have tried to create a python plugin but even that all it did was login
and list the playlists it was to slow.

My code is written in such a way so that it could (pretty) easily be
extracted and put in a binary addon when XBMC gain support for it.

Regards
David

2011/9/27 John Hamelink <
[email protected]>

Hi there,

I was looking through the internet for a plugin for XBMC that would allow
me to play music via spotify. This plugin seems to be the only thing out
there!

The problem is, I'm not too keen on the idea of recompiling XBMC in order
to get this functionality, so I'm wondering how feasible it would be to make
a true plugin for spotify which would allow for use on a vanilla copy of
XBMC, either using this code, or by writing my own?

Also, what were your reasons for editing XBMC's code? Could some of the
code be worked into the official XBMC codebase?

Thanks,
John :)

Reply to this email directly or view it on GitHub:
#8

@johnhamelink
Copy link
Author

So would you say it'd be possible to build an application that handles the actual "spotifying", then simply use xbmc as a frontend to the external application? This application could be downloaded on first load and then ran and killed when the plugin is / is not in use?

@akezeke
Copy link
Owner

akezeke commented Sep 28, 2011

I guess it is possible, there are some problems though.

You can't integrate it into the music section, it would be a standard
plugin.

The actual playing of the music should be made diffently since XBMC doesn't
support codecs to be addons.

There are probably a lot of other problems turning up but if you would like
try you should start with extracting the spotify code to a separate
application and look into the interface. I'm not a skilled python developer
nor a xbmc addon expert so I don't know much how that part would be coded.

/David
Den 28 sep 2011 09:57 skrev "John Hamelink" <
[email protected]>:

So would you say it'd be possible to build an application that handles the
actual "spotifying", then simply use xbmc as a frontend to the external
application? This application could be downloaded on first load and then ran
and killed when the plugin is / is not in use?

Reply to this email directly or view it on GitHub:
#8 (comment)

@WebSpider
Copy link

Are there any plans on basing this on Eden?

Also, I'd be very interested in Spotify support in OpenElec, it would make sense to have this as a plugin there as well, since OpenElec releases quite often, would be a pain to keep up :)

@akezeke
Copy link
Owner

akezeke commented Dec 4, 2011

spotyXBMC is based on Eden (pre)!

There is a version of OpenElec with spotyXBMC integration thanks to Tompen, read about it here: http://openelec.tv/forum/13-general-discussion/7010-spotify.

@nougad
Copy link

nougad commented May 25, 2012

Hi,

stupid question but have you tried to get this features into xbmc? I found a old Ticket1. They mentioned a pull request but I've found none. I created a patch against the merged xbmc version an it is relative small in comparison to the huge changes:

-w = no whitespace
grep -v - removed files related to spotify - Patch should only contain changes to xbmc plugin system
grep -v org$ - original files? why in repository?
xbmc/configure.in - necessary?

$ git diff --numstat -w mergepoint master | grep -v spotyXBMC | grep -v spotify | grep -v org$ | grep -v xbmc/configure.in | sort -n
0   0   addons/skin.confluence/720p/MusicOSD.xml                  <- only whitespace changes :(
0   0   addons/skin.confluence/720p/MusicOverlay.xml             <- only whitespace changes :(
0   0   xbmc/interfaces/json-rpc/JSONRPC.h                             <- only whitespace changes :(
0   0   xbmc/interfaces/json-rpc/JSONServiceDescription.cpp   <- only whitespace changes :(
0   0   xbmc/interfaces/json-rpc/PlaylistOperations.cpp             <- only whitespace changes :(
1   0   xbmc/interfaces/json-rpc/methods.json
1   0   xbmc/XBApplicationEx.cpp
1   1   .gitignore
1   1   xbmc/music/tags/MusicInfoTagLoaderWMA.cpp
1   1   xbmc/settings/AdvancedSettings.h
2   0   xbmc/settings/AdvancedSettings.cpp
2   1   xbmc/settings/Settings.cpp
2   2   xbmc/music/windows/GUIWindowMusicPlaylist.cpp
3   0   configure.in
3   0   xbmc/settings/AppParamParser.cpp
3   1   xbmc/GUIInfoManager.cpp
5   0   xbmc/interfaces/json-rpc/types.json
5   1   xbmc/filesystem/MusicSearchDirectory.cpp
6   0   xbmc/cores/paplayer/CodecFactory.cpp
6   0   xbmc/filesystem/MusicDatabaseDirectory/DirectoryNodeTop100.cpp
6   1   xbmc/dialogs/GUIDialogContextMenu.h
7   0   xbmc/filesystem/MusicDatabaseDirectory/DirectoryNodeOverview.cpp
7   1   xbmc/interfaces/json-rpc/ServiceDescription.h
8   0   xbmc/Application.h
8   0   xbmc/music/windows/GUIWindowMusicBase.cpp
8   2   xbmc/interfaces/json-rpc/FileItemHandler.cpp
8   7   xbmc/cores/dvdplayer/DVDCodecs/Video/VDPAU.h
9   5   xbmc/filesystem/MusicDatabaseDirectory/DirectoryNodeSong.cpp
13  9   xbmc/filesystem/MusicDatabaseDirectory/DirectoryNodeAlbum.cpp
13  9   xbmc/filesystem/MusicDatabaseDirectory/DirectoryNodeArtist.cpp
31  11  addons/webinterface.default/js/MediaLibrary.js
32  0   xbmc/music/Makefile
35  5   xbmc/interfaces/json-rpc/AudioLibrary.cpp
48  0   xbmc/music/windows/GUIWindowMusicNav.cpp
57  2   addons/skin.confluence/720p/MusicVisualisation.xml
76  12  project/VS2010Express/XBMC.vcxproj
98  9   xbmc/Application.cpp
100 99  xbmc/interfaces/Builtins.cpp
225 0   project/VS2010Express/XBMC.vcxproj.filters
244 0   Readme.md
add  del

I think with a little bit clean up you should try to include this "extended plugin system" in xbmc via pull request. What do you think?

@JoA-MoS
Copy link

JoA-MoS commented Sep 29, 2013

I know this Idea probably doesn't meet all the features that the full compiled version provides but have any of you ever used spotimote? It is an app for Android that Controls the spotify app from your phone. On your phone it displays Album Art, Artist Info, you can search, see favorites, starred, playlists, queue, history, downloaded music (personal), library, inbox, downloads. It functions through a companion app (server) you install on your PC and controls the official spotify application. http://www.evolu-on.com/spotimote.html

My thought would be just to build a plugin for XBMC that makes the same calls that the android App makes to get the information from the companion app.... Just a thought...

I will let you know what I think of spotyxbmc2 once i get it compiled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants