New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a "bug"? in the cpo method #8

Open

xzhang2523 opened this issue Feb 21, 2023 · 1 comment

xzhang2523 commented Feb 21, 2023

reward_advs -= reward_advs.mean()
reward_advs /= reward_advs.std()
cost_advs -= \textbf{reward_advs}.mean()
cost_advs /= cost_advs.std()

I guess on line 3, it should be mean of the cost?

Owner

ajlangley commented Feb 23, 2023

You are right. If you want to make any changes to the repo and make a PR, I'm happy to merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment