fix(property chunking): fix delimiter count since commas are encoded as three characters (#495)

Author: brianjlai

airbyte_cdk/sources/declarative/requesters/query_properties/property_chunking.py

@@ -55,7 +55,7 @@ def get_request_property_chunks(
             # todo: Add ability to specify parameter delimiter representation and take into account in property_field_size
             property_field_size = (
                 len(property_field)
-                + 1  # The +1 represents the extra character for the delimiter in between properties
+                + 3  # The +3 represents the extra characters for encoding the delimiter in between properties
                 if self.property_limit_type == PropertyLimitType.characters
                 else 1
             )

unit_tests/sources/declarative/requesters/query_properties/test_property_chunking.py

@@ -43,15 +43,15 @@
             ["kate", "laurie", "jaclyn"],
             None,
             PropertyLimitType.characters,
-            15,
+            20,
             [["kate", "laurie"], ["jaclyn"]],
             id="test_property_chunking_limit_characters",
         ),
         pytest.param(
             ["laurie", "jaclyn", "kaitlin"],
             None,
             PropertyLimitType.characters,
-            12,
+            17,  # laurie%2Cjaclyn%2C == 18, so this will create separate chunks
             [["laurie"], ["jaclyn"], ["kaitlin"]],
             id="test_property_chunking_includes_extra_delimiter",
         ),