Skip to content

Commit 9e0744f

Browse files
committed
Fix most of the tests
1 parent 435bce2 commit 9e0744f

File tree

9 files changed

+17
-18
lines changed

9 files changed

+17
-18
lines changed

Diff for: __tests__/jest/components/nodeImpl/Svg.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ jest.mock('../../../../src/jsonUtils/models', () => ({
1010
}));
1111

1212
describe('node <Svg />', () => {
13-
it('generates the json for an svg', () => {
13+
it('generates the json for an svg', async () => {
1414
class SVGElement extends React.Component {
1515
render() {
1616
return (
@@ -26,6 +26,6 @@ describe('node <Svg />', () => {
2626
}
2727
}
2828

29-
expect(ReactSketch.renderToJSON(<SVGElement />)).toMatchSnapshot();
29+
expect(await ReactSketch.renderToJSON(<SVGElement />)).toMatchSnapshot();
3030
});
3131
});

Diff for: __tests__/jest/index.ts

+1-5
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,5 @@
11
/* eslint-disable global-require */
2-
import ReactSketch from '../../src';
3-
jest.mock('../../src/jsonUtils/sketchImpl/createStringMeasurer');
4-
jest.mock('../../src/jsonUtils/sketchImpl/findFontName');
5-
jest.mock('../../src/jsonUtils/sketchImpl/makeImageDataFromUrl');
6-
jest.mock('../../src/jsonUtils/sketchImpl/makeSvgLayer');
2+
import * as ReactSketch from '../../src';
73

84
describe('public API', () => {
95
it('exports render', () => {

Diff for: __tests__/jest/jsonUtils/computeYogaNode.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import yoga from 'yoga-layout-prebuilt';
22
import computeYogaNode from '../../../src/jsonUtils/computeYogaNode';
33
import Context from '../../../src/utils/Context';
4+
import NodeMacOSBridge from '../../../src/platformBridges/NodeMacOSBridge';
45

56
const widthAndHeightStylesStub = {
67
width: 10,
@@ -32,7 +33,7 @@ const createYogaNodes = (
3233
styles.forEach(style => {
3334
const treeNode = createTreeNode(style);
3435
const ctx = new Context();
35-
const { node } = computeYogaNode(treeNode, ctx);
36+
const { node } = computeYogaNode(treeNode, ctx, NodeMacOSBridge);
3637
node.calculateLayout(
3738
containerWidth || undefined,
3839
containerHeight || undefined,

Diff for: __tests__/jest/jsonUtils/computeYogaTree.ts

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import yoga from 'yoga-layout-prebuilt';
22
import computeYogaTree from '../../../src/jsonUtils/computeYogaTree';
33
import Context from '../../../src/utils/Context';
4+
import NodeMacOSBridge from '../../../src/platformBridges/NodeMacOSBridge';
45

56
const treeRootStub = {
67
type: 'artboard',
@@ -35,11 +36,11 @@ const treeRootStub = {
3536
],
3637
};
3738

38-
computeYogaTree(treeRootStub, new Context());
39+
computeYogaTree(treeRootStub, new Context(), NodeMacOSBridge);
3940

4041
describe('Compute Yoga Tree', () => {
4142
it('correctly create yoga nodes into layout tree', () => {
42-
const yogaTree = computeYogaTree(treeRootStub, new Context());
43+
const yogaTree = computeYogaTree(treeRootStub, new Context(), NodeMacOSBridge);
4344
yogaTree.calculateLayout(undefined, undefined, yoga.DIRECTION_LTR);
4445
expect(yogaTree.getComputedLayout()).toEqual({
4546
bottom: 0,

Diff for: __tests__/jest/reactTreeToFlexTree.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import yoga from 'yoga-layout-prebuilt';
22
import computeYogaTree from '../../src/jsonUtils/computeYogaTree';
33
import Context from '../../src/utils/Context';
44
import { reactTreeToFlexTree } from '../../src/buildTree';
5+
import NodeMacOSBridge from '../../src/platformBridges/NodeMacOSBridge';
56

67
const treeRootStub = {
78
type: 'artboard',
@@ -55,7 +56,7 @@ const treeRootStub = {
5556

5657
describe('Compute Flex Tree', () => {
5758
it('correctly creates flex tree', () => {
58-
const yogaNode = computeYogaTree(treeRootStub, new Context());
59+
const yogaNode = computeYogaTree(treeRootStub, new Context(), NodeMacOSBridge);
5960
yogaNode.calculateLayout(undefined, undefined, yoga.DIRECTION_LTR);
6061
const tree = reactTreeToFlexTree(treeRootStub, yogaNode, new Context());
6162

Diff for: __tests__/jest/sharedStyles/TextStyles.ts

+5-5
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ beforeEach(() => {
77
jest.resetModules();
88

99
jest.mock('../../../src/utils/getSketchVersion', () => ({
10-
getSketchVersion: jest.fn(() => 51),
10+
default: jest.fn(() => '51'),
1111
}));
1212

1313
TextStyles = require('../../../src/sharedStyles/TextStyles');
@@ -16,10 +16,10 @@ beforeEach(() => {
1616

1717
jest.mock('../../../src/utils/sharedTextStyles');
1818

19-
jest.mock('../../../src/jsonUtils/sketchImpl/createStringMeasurer');
20-
jest.mock('../../../src/jsonUtils/sketchImpl/findFontName');
21-
jest.mock('../../../src/jsonUtils/sketchImpl/makeImageDataFromUrl');
22-
jest.mock('../../../src/jsonUtils/sketchImpl/makeSvgLayer');
19+
// jest.mock('../../../src/jsonUtils/sketchImpl/createStringMeasurer');
20+
// jest.mock('../../../src/jsonUtils/sketchImpl/findFontName');
21+
// jest.mock('../../../src/jsonUtils/sketchImpl/makeImageDataFromUrl');
22+
// jest.mock('../../../src/jsonUtils/sketchImpl/makeSvgLayer');
2323

2424
TextStyles = TextStyles.default;
2525
sharedTextStyles = sharedTextStyles.default;

Diff for: src/index.node.ts renamed to src/index.ts

File renamed without changes.

Diff for: src/jsonUtils/makeSvgLayer/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ import isRunningInSketch from '../../utils/isRunningInSketch';
22
import sketchMakeSvgLayer from './makeSvgLayer.sketch';
33
import pureJsSketchMakeSvgLayer from './makeSvgLayer';
44

5-
export default isRunningInSketch() ? pureJsSketchMakeSvgLayer : sketchMakeSvgLayer;
5+
export default isRunningInSketch() ? sketchMakeSvgLayer : pureJsSketchMakeSvgLayer;

Diff for: src/jsonUtils/makeSvgLayer/makeSvgLayer.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ export default async function makeSvgLayer(
8383
svg: string,
8484
): Promise<FileFormat.Group> {
8585
// Load the module only if it has been made available through another import.
86-
const svgModel = await import(/* webpackMode: "weak" */ '@lona/svg-model');
86+
const svgModel = (await import(/* webpackMode: "weak" */ '@lona/svg-model')).default;
8787

8888
const {
8989
data: { params, children },

0 commit comments

Comments
 (0)