-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RTL text support #1145
Comments
@ArthurVimond Awesome! |
@gpeal |
@ArthurVimond Sounds good :) Rebase on master as I did some work in TextLayer for unicode support today. |
This detects perfectly weather the text is RTL or LTR, So based on that we just need to put the right direction accordingly. |
For anyone looking for a solution to do that for Lottie with Compose, I flipped the lottie composition by scaling the animation to the other direction like that.
and
|
Hi!
I'm currently working on adding RTL text support, and I have a few questions:
1- Should we detect the direction for each TextLayer input and draw them independently or just getting the device current language setting and apply the same direction for all texts?
2- Regarding the text justification, drawing RTL texts with Justification.LEFT_ALIGN should start from the right (not from the left), right? Also, should we refactor the Justification enums as START_ALIGN, CENTER, END_ALIGN (like layout margin / padding system)?
Thanks.
The text was updated successfully, but these errors were encountered: