Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project 1 Feedback [Zilean] #67

Open
impiyush83 opened this issue Feb 10, 2022 · 1 comment
Open

Project 1 Feedback [Zilean] #67

impiyush83 opened this issue Feb 10, 2022 · 1 comment
Assignees

Comments

@impiyush83
Copy link

Likes:

  • Development looks crisp and as per industry standards.
  • SDLC processes and contributing guidelines are great!

Observations:

  • Each microservice needs to make an API call to database-connect microservice to make DB operations. Here, it increases one network hop which might hamper performance.

Piyush Nalawade

  • Team Zilean 🦄
@RutujaJadhav19
Copy link
Contributor

RutujaJadhav19 commented Feb 10, 2022

Hi Piyush,

Thanks for taking the time to review our project. Appreciate your feedback. The reason to implement every microservice connect to database-connect microservice to make DB operations is to follow the project guidelines given in Project 1 which states "Only one microservice can connect to each DBMS". We are using only one DBMS(Mongo DB) for our application and hence only database-connect microservice will connect to our database to perform any DB operations.

Team Scapsulators

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants