Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer Review Milestone 4 #189

Open
Praneta-Paithankar opened this issue Apr 25, 2019 · 1 comment
Open

Peer Review Milestone 4 #189

Praneta-Paithankar opened this issue Apr 25, 2019 · 1 comment
Labels
Peer review Peer review comments / issues

Comments

@Praneta-Paithankar
Copy link

Hello Team,

I like the UI. It is user-friendly and easy to navigate. However, I found a few issues while reviewing the code.

  1. Sign up is not working. As mentioned in previous issue Sign up issue #186
  2. After clicking on the song, the song is not played automatically.
  3. Also, Song tile does not show the complete title.

Just a few suggestions:

  1. I think songs suggestion based on news consider the news trending in the country. But it would be nice to include local events.
@Praneta-Paithankar Praneta-Paithankar added the Peer review Peer review comments / issues label Apr 25, 2019
@sairohithA007
Copy link
Contributor

Thanks for the feedback points @Praneta-Paithankar. We will address the issues one by one.
Currently, we are working on #186 . Hopefully will be fixed by tonight/tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Peer review Peer review comments / issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Praneta-Paithankar @sairohithA007