Skip to content

Conversation

@ovidiusm
Copy link
Contributor

What?

Nixlbench should allocate page aligned memory for best performance in tests involving DRAM.

Why?

  • Transfers from unaligned memory may be slower. Applications should use aligned memory wherever possible for best performance.
  • Easier comparison with ucx_perftest and similar

@github-actions
Copy link

👋 Hi ovidiusm! Thank you for contributing to ai-dynamo/nixl.

Your PR reviewers will review your contribution then trigger the CI to test your changes.

🚀

@ovidiusm
Copy link
Contributor Author

/build

@brminich
Copy link
Contributor

should xferBenchUtils::checkConsistency be also updated?

@ovidiusm
Copy link
Contributor Author

should xferBenchUtils::checkConsistency be also updated?

I do not think so, it is outside the time measurements

Signed-off-by: Ovidiu Mara <[email protected]>
Signed-off-by: Ovidiu Mara <[email protected]>
@ovidiusm
Copy link
Contributor Author

/build

1 similar comment
@ovidiusm
Copy link
Contributor Author

/build

@ovidiusm
Copy link
Contributor Author

/build

@brminich
Copy link
Contributor

/build

@brminich
Copy link
Contributor

brminich commented Dec 1, 2025

should xferBenchUtils::checkConsistency be also updated?

I do not think so, it is outside the time measurements

let me rephrase - why do we need different allocation methods in that method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants