-
Notifications
You must be signed in to change notification settings - Fork 192
nixlbench: allocate page aligned memory by default #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Ovidiu Mara <[email protected]>
|
👋 Hi ovidiusm! Thank you for contributing to ai-dynamo/nixl. Your PR reviewers will review your contribution then trigger the CI to test your changes. 🚀 |
|
/build |
|
should |
I do not think so, it is outside the time measurements |
Co-authored-by: Raul Akhmetshin <[email protected]> Signed-off-by: ovidiusm <[email protected]>
Co-authored-by: Raul Akhmetshin <[email protected]> Signed-off-by: ovidiusm <[email protected]>
Signed-off-by: Ovidiu Mara <[email protected]>
Signed-off-by: Ovidiu Mara <[email protected]>
|
/build |
1 similar comment
|
/build |
|
/build |
|
/build |
let me rephrase - why do we need different allocation methods in that method? |
What?
Nixlbench should allocate page aligned memory for best performance in tests involving DRAM.
Why?