Skip to content

Commit 5850441

Browse files
committed
Add comment explaining window args
1 parent e6d8776 commit 5850441

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

pycroft/lib/membership.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -212,6 +212,8 @@ def select_user_and_last_mem() -> Select: # Select[Tuple[int, int, str]]
212212
"""
213213
mem_ends_at = func.upper(Membership.active_during)
214214
# see FunctionElement.over for documentation on `partition_by`, `order_by`
215+
# ideally, sqlalchemy would support named windows;
216+
# instead, we have to re-use the arguments.
215217
window_args: dict[str, ClauseElement | t.Sequence[ClauseElement | str] | None] = {
216218
"partition_by": User.id,
217219
"order_by": nulls_last(mem_ends_at),

0 commit comments

Comments
 (0)