Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible typo? #3

Open
gl7176 opened this issue Oct 22, 2024 · 1 comment
Open

Possible typo? #3

gl7176 opened this issue Oct 22, 2024 · 1 comment

Comments

@gl7176
Copy link

gl7176 commented Oct 22, 2024

Hey Anna, Greg here! Patrick just shared this and it's a treasure trove - nice work! I'm learning a lot from your use of the cameratransform package. We have a bunch of imagery of otters in kelp and seals on glacial icebergs and I'm trying to project imagery onto the sea surface / spatial coordinates from Wingtra flight logs. I was starting to code all the trigonometry from scratch, but it's a godsend that there's a package for this!

As I was copying your "ct." functions over I found this line here, " coords : np.absndarray = np.array( " etc,, and I don't recognize the syntax and it's throwing an error around "np.absndarray" which I also don't recognize/can't find online. So I thought I'd flag it as a potential typo - I was able to get my own code working by reducing it to "coords = np.array( ", and then I was able to reference the coords as normal to GCPs and bounding box polygons.

DroneWQ/utils.py

Line 1088 in a104709

coords : np.absndarray = np.array([cam.gpsFromImage([0, 0]), cam.gpsFromImage([image_size[0] - 1, 0]),

@aewindle110
Copy link
Owner

Hi Greg! So glad you've found the code useful. We are planning to submit the repo to JOSS very soon.

Thank you for pointing out that typo! I've changed the line in utils.py. You're right, it should have been "coords = np.array(".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants