FIX: Ensure commands sent to serial port by routines end in \n

Author: cortadocodes

data_gateway/cli.py

@@ -371,7 +371,8 @@ def _get_serial_port(serial_port, configuration, use_dummy_serial_port):
 
 def _load_routine(routine_path, interactive, serial_port):
     """Load a sensor commands routine from the path if exists, otherwise return no routine. If in interactive mode, the
-    routine file is ignored.
+    routine file is ignored. Note that "\n" has to be added to the end of each command sent to the serial port for it to
+    be executed - this is done automatically in this method.
 
     :param str routine_path:
     :param bool interactive:
@@ -383,7 +384,10 @@ def _load_routine(routine_path, interactive, serial_port):
             logger.warning("Sensor command routine files are ignored in interactive mode.")
         else:
             with open(routine_path) as f:
-                routine = Routine(**json.load(f), action=lambda command: serial_port.write(command.encode("utf_8")))
+                routine = Routine(
+                    **json.load(f),
+                    action=lambda command: serial_port.write((command + "\n").encode("utf_8")),
+                )
 
             logger.info("Loaded routine file from %r.", routine_path)
             return routine

setup.cfg

@@ -23,4 +23,4 @@ force_grid_wrap=0
 combine_as_imports=True
 
 [pydocstyle]
-ignore = D100, D101, D104, D105, D107, D203, D205, D213, D400, D415
+ignore = D100, D101, D104, D105, D107, D203, D205, D213, D301, D400, D415