You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not all C++11 compilers are equal. Such as various older releases of Visual Studio (right after 11 started showing up) and gcc that don't fully support every piece of the standard.
So, while C++11 is suggested, we try to make it as optional as possible to have the broadest base.
Sure, that's why it's better to target some common platforms (Ubuntu LTS, Centos, SUSE, whatever is common non-EOL VS) and run CI against them. I'm pretty sure all of them have compilers with enum class support.
Using enum class could improve type safety in the C++ API. It would also be a API breakage.Something to consider for the future.
Activity
tmontgomery commentedon Jun 11, 2019
Sure. Send a PR and I will look at it.
manuka89 commentedon Jun 11, 2019
You mean PR=Pull Request?
tmontgomery commentedon Jun 11, 2019
Yes
rigtorp commentedon Aug 26, 2019
@tmontgomery Does this project require C++11 or higher? Because that is needed for enum classes.
If we do require C++11 or higher we could remove the
SBE_NOEXCEPT
andSBE_CONSTEXPR
macro.tmontgomery commentedon Aug 26, 2019
Not all C++11 compilers are equal. Such as various older releases of Visual Studio (right after 11 started showing up) and gcc that don't fully support every piece of the standard.
So, while C++11 is suggested, we try to make it as optional as possible to have the broadest base.
rigtorp commentedon Aug 26, 2019
Sure, that's why it's better to target some common platforms (Ubuntu LTS, Centos, SUSE, whatever is common non-EOL VS) and run CI against them. I'm pretty sure all of them have compilers with
enum class
support.Using
enum class
could improve type safety in the C++ API. It would also be a API breakage.Something to consider for the future.I will create a separate issue for this.