Skip to content

Commit 338b274

Browse files
committed
[Java] Create DTO generator only if enabled.
1 parent 153c985 commit 338b274

File tree

1 file changed

+24
-22
lines changed

1 file changed

+24
-22
lines changed

sbe-tool/src/main/java/uk/co/real_logic/sbe/generation/TargetCodeGeneratorLoader.java

Lines changed: 24 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -54,23 +54,23 @@ public CodeGenerator newInstance(final Ir ir, final String outputDir)
5454
ir,
5555
System.getProperty(JAVA_ENCODING_BUFFER_TYPE, JAVA_DEFAULT_ENCODING_BUFFER_TYPE),
5656
System.getProperty(JAVA_DECODING_BUFFER_TYPE, JAVA_DEFAULT_DECODING_BUFFER_TYPE),
57-
"true".equals(System.getProperty(JAVA_GROUP_ORDER_ANNOTATION)),
58-
"true".equals(System.getProperty(JAVA_GENERATE_INTERFACES)),
59-
"true".equals(System.getProperty(DECODE_UNKNOWN_ENUM_VALUES)),
60-
"true".equals(System.getProperty(TYPES_PACKAGE_OVERRIDE)),
57+
Boolean.getBoolean(JAVA_GROUP_ORDER_ANNOTATION),
58+
Boolean.getBoolean(JAVA_GENERATE_INTERFACES),
59+
Boolean.getBoolean(DECODE_UNKNOWN_ENUM_VALUES),
60+
Boolean.getBoolean(TYPES_PACKAGE_OVERRIDE),
6161
precedenceChecks(),
6262
outputManager);
6363

64-
final JavaDtoGenerator dtoGenerator = new JavaDtoGenerator(ir, outputManager);
65-
66-
final CodeGenerator combinedGenerator = () ->
64+
if (Boolean.getBoolean(JAVA_GENERATE_DTOS))
6765
{
68-
codecGenerator.generate();
69-
dtoGenerator.generate();
70-
};
71-
72-
final boolean generateDtos = "true".equals(System.getProperty(JAVA_GENERATE_DTOS));
73-
return generateDtos ? combinedGenerator : codecGenerator;
66+
final JavaDtoGenerator dtoGenerator = new JavaDtoGenerator(ir, outputManager);
67+
return () ->
68+
{
69+
codecGenerator.generate();
70+
dtoGenerator.generate();
71+
};
72+
}
73+
return codecGenerator;
7474
}
7575
},
7676

@@ -100,19 +100,21 @@ public CodeGenerator newInstance(final Ir ir, final String outputDir)
100100
{
101101
final NamespaceOutputManager outputManager = new NamespaceOutputManager(
102102
outputDir, ir.applicableNamespace());
103-
final boolean decodeUnknownEnumValues = "true".equals(System.getProperty(DECODE_UNKNOWN_ENUM_VALUES));
103+
final boolean decodeUnknownEnumValues = Boolean.getBoolean(DECODE_UNKNOWN_ENUM_VALUES);
104104

105105
final CodeGenerator codecGenerator = new CppGenerator(ir, decodeUnknownEnumValues, precedenceChecks(),
106106
outputManager);
107-
final CodeGenerator dtoGenerator = new CppDtoGenerator(ir, outputManager);
108-
final CodeGenerator combinedGenerator = () ->
109-
{
110-
codecGenerator.generate();
111-
dtoGenerator.generate();
112-
};
113107

114-
final boolean generateDtos = "true".equals(System.getProperty(CPP_GENERATE_DTOS));
115-
return generateDtos ? combinedGenerator : codecGenerator;
108+
if (Boolean.getBoolean(CPP_GENERATE_DTOS))
109+
{
110+
final CodeGenerator dtoGenerator = new CppDtoGenerator(ir, outputManager);
111+
return () ->
112+
{
113+
codecGenerator.generate();
114+
dtoGenerator.generate();
115+
};
116+
}
117+
return codecGenerator;
116118
}
117119
},
118120

0 commit comments

Comments
 (0)