Mbin support

[ismailkarsli]

I'm thinking of creating a PR to replace the client used in Lemmy Federate with this library. However, the lack of Mbin support is not backwards compatible. I'd like to create a PR for this library, but I don't have time to implement the entire Mbin. Would it be sufficient to just add the features required by Lemmy Federate?

It's just 3 methods and an interface: https://github.com/Fedihosting-Foundation-Forks/lemmy-federate/blob/main/src/types/LFClient.ts

cc @MrKaplan-lw @aeharding

[aeharding]

Hey thanks!

I actually started to implement this last summer but ran into some roadblocks, not sure if it will affect you but assuming not?:

https://github.com/MbinOrg/mbin/issues?q=is%3Aissue%20state%3Aopen%20author%3Aaeharding

https://github.com/aeharding/threadiverse/tree/mbin

[ismailkarsli]

I see. Since Lemmy Federate is completely server-side, CORS issues won't be a problem. Actually, I think it shouldn't be an issue on the Voyager mobile version either. Can we just ignore CORS here for now?

From what I can see, you have set up the base structure. All I might need to implement is adding these functions: getCommunity, followCommunity, and listCommunities. Perhaps we could add something extra related to posts and comments.

There is also an issue I'm seeing here: not every Mbin instance allows the creation of an OAuth client. Meaning, some of them only allow admins to create one. How can we handle this? Maybe the client ID could be hard-coded into the client? This one is for Voyager. Lemmy Federate already requires admins to submit their OAuth client credentials.