-
Notifications
You must be signed in to change notification settings - Fork 558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Scanner does not automatically create chapters if "Audio file meta tags OR ebook metadata" is turned off #3829
Comments
I'd like to add that I could not find any description of this behavior in the guides https://www.audiobookshelf.org/guides/book-scanner . For quite some time I was even under impression that "no automatic chapters" is an audiobookshelf limitation! In retrospect I think it makes sense the scanner MIGHT need access to media tags for chapter creation to avoid unneeded complexity. If this is the case, it is probably good to document it somewhere. |
How would you describe it more clearly? When chapters are embedded in the file metadata, that is a metadata tag for the media files. Edit to add: I'm asking so we can update the docs, because to me it is clear as written. |
@nichwall let's make sure we are talking about the same thing first. Let me pick a specific example:
My expectation was that "Audio file meta tags OR ebook metadata" flag controls if Audiobookshelf pulls data from the file meta tags (like MP3 "title" tag). Thus my expectation was that for such a book this setting has no effect. However, the actual behavior is:
If this is intentional I expect something like that in the documentation: So if scanner |
I would consider that a bug. The logic for setting book chapters is in the audio file metatags scanner which is skipped if that is disabled. |
What happened?
I have disabled "Audio file meta tags OR ebook metadata" in the "Scanner" tab in the "Add Library" dialog. The scan completed fine, but none of my audiobooks (MP3 folder) had any chapters.
However, when I created a new Library with "Audio file meta tags OR ebook metadata" enabled, chapters were detected correctly. Chapter names were derived from file names and/or MP3 tags depending on the availability as expected.
This was slightly inconvinient, as MP3 tags on some of the books were not correctly UTF-encoded, and I had to mass-clean them up first.
What did you expect to happen?
I expected that "Audio file meta tags OR ebook metadata" is not a mandatory settings for chapter detection. I expected that chapters would be created by the scanner from the file names only if I have it disabled.
Steps to reproduce the issue
\audiobooks\author1\book1\track1.mp3
, ...Audiobookshelf version
2.17.5
How are you running audiobookshelf?
Docker
What OS is your Audiobookshelf server hosted from?
Other (list in "Additional Notes" box)
If the issue is being seen in the UI, what browsers are you seeing the problem on?
None
Logs
Additional Notes
Running in docker on Synology NAS.
The text was updated successfully, but these errors were encountered: