CDS extractor constant for model.cds.json filename

This commit replaces many separate string literals for `model.cds.json`
with an exported constant of the same string in an effort to improve
the readability and maintainability of CDS extractor code.

Author: data-douser

extractors/cds/tools/dist/cds-extractor.bundle.js

@@ -3,6 +3,7 @@ import { resolve, join, delimiter, relative, dirname, basename } from 'path';
 
 import { CdsCompilationResult } from './types';
 import { getCdsVersion } from './version';
+import { modelCdsJsonFile } from '../../constants';
 import { fileExists, dirExists, recursivelyRenameJsonFiles } from '../../filesystem';
 import { cdsExtractorLog } from '../../logging';
 import { BasicCdsProject } from '../parser/types';
@@ -60,7 +61,7 @@ function determineCompilationTargets(project: BasicCdsProject, sourceRoot: strin
  * Compiles a CDS project to JSON using project-level compilation only.
  * This function has been simplified to only use project-level compilation,
  * eliminating all individual file compilation logic and standardizing output
- * to a single model.cds.json file per project.
+ * to a single {@link modelCdsJsonFile} file per project.
  *
  *
  * @param cdsFilePath The path to the CDS file to compile, relative to the `sourceRoot`.
@@ -146,16 +147,15 @@ function compileProject(
     );
   }
 
-  // Generate output path for the compiled model - always model.cds.json in project base directory
-  const projectJsonOutPath = join(sourceRoot, projectDir, 'model.cds.json');
+  const projectJsonOutPath = join(sourceRoot, projectDir, modelCdsJsonFile);
 
   const compileArgs = [
     'compile',
     ...compilationTargets,
     '--to',
     'json',
     '--dest',
-    'model.cds.json',
+    modelCdsJsonFile,
     '--locations',
     '--log-level',
     'warn',

extractors/cds/tools/dist/cds-extractor.bundle.js.map

@@ -4,6 +4,7 @@ import { basename, dirname, join, relative, sep } from 'path';
 import { sync } from 'glob';
 
 import { CdsFilesToCompile, CdsImport, PackageJson } from './types';
+import { modelCdsJsonFile } from '../../constants';
 import { cdsExtractorLog } from '../../logging';
 
 /**
@@ -415,7 +416,7 @@ export function determineCdsFilesToCompile(
   if (!project.cdsFiles || project.cdsFiles.length === 0) {
     return {
       compilationTargets: [],
-      expectedOutputFile: join(project.projectDir, 'model.cds.json'),
+      expectedOutputFile: join(project.projectDir, modelCdsJsonFile),
     };
   }
 
@@ -429,7 +430,7 @@ export function determineCdsFilesToCompile(
     // Use standard CAP directories
     return {
       compilationTargets: existingCapDirs,
-      expectedOutputFile: join(project.projectDir, 'model.cds.json'),
+      expectedOutputFile: join(project.projectDir, modelCdsJsonFile),
     };
   }
 
@@ -442,7 +443,7 @@ export function determineCdsFilesToCompile(
     // Use root-level files
     return {
       compilationTargets: rootCdsFiles,
-      expectedOutputFile: join(project.projectDir, 'model.cds.json'),
+      expectedOutputFile: join(project.projectDir, modelCdsJsonFile),
     };
   }
 
@@ -453,7 +454,7 @@ export function determineCdsFilesToCompile(
 
   return {
     compilationTargets,
-    expectedOutputFile: join(project.projectDir, 'model.cds.json'),
+    expectedOutputFile: join(project.projectDir, modelCdsJsonFile),
   };
 }
 

extractors/cds/tools/src/cds/compiler/compile.ts

@@ -8,6 +8,7 @@ import {
   readPackageJsonFile,
 } from './functions';
 import { CdsDependencyGraph, CdsImport, CdsProject, BasicCdsProject } from './types';
+import { modelCdsJsonFile } from '../../constants';
 import { cdsExtractorLog } from '../../logging';
 
 /**
@@ -44,7 +45,7 @@ function buildBasicCdsProjectDependencyGraph(sourceRootDir: string): Map<string,
       projectDir,
       cdsFiles,
       compilationTargets: [], // Will be populated in the third pass
-      expectedOutputFile: join(projectDir, 'model.cds.json'), // Always model.cds.json, relative to source root
+      expectedOutputFile: join(projectDir, modelCdsJsonFile),
       packageJson,
       dependencies: [],
       imports: new Map<string, CdsImport[]>(),
@@ -170,7 +171,7 @@ function buildBasicCdsProjectDependencyGraph(sourceRootDir: string): Map<string,
       );
       // Fall back to default project compilation on error
       project.compilationTargets = project.cdsFiles.map(file => basename(file));
-      project.expectedOutputFile = join(project.projectDir, 'model.cds.json');
+      project.expectedOutputFile = join(project.projectDir, modelCdsJsonFile);
     }
   }
 

extractors/cds/tools/src/cds/parser/functions.ts

@@ -0,0 +1,7 @@
+/** Common constants used throughout the CDS extractor. */
+
+/**
+ * Common, expected name of the JSON file created by CDS compilation
+ * tasks performed by, or on behalf of, the CDS extractor.
+ */
+export const modelCdsJsonFile = 'model.cds.json';