Skip to content

Commit a9f6f88

Browse files
authored
set default use_new_renderer to true (#160)
* set default use_new_renderer to true update dependencies * setting kotlin and agp versions to max supported according to https://kotlinlang.org/docs/multiplatform-compatibility-guide.html#version-compatibility * updates test
1 parent 1ec9320 commit a9f6f88

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

gradle/libs.versions.toml

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
android = "8.7.2"
33
dokka = "1.9.20"
44
kotest = "6.0.0.M1"
5-
kotlin = "2.0.21"
6-
serialization = { require = "[1.4, 2.0[", prefer = "1.7.3" }
5+
kotlin = "2.1.0"
6+
serialization = { require = "[1.4, 2.0[", prefer = "1.8.0" }
77

88
[plugins]
99
android = { id = "com.android.library", version.ref = "android" }

kotlin/src/commonMain/kotlin/com/adsbynimbus/openrtb/response/BidResponse.kt

+1-1
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,6 @@ public class BidResponse(
8989
*/
9090
@Serializable
9191
public class Extension(
92-
@JvmField @SerialName("use_new_renderer") public val use_new_renderer: Boolean = false,
92+
@JvmField @SerialName("use_new_renderer") public val use_new_renderer: Boolean = true,
9393
)
9494
}

kotlin/src/commonTest/kotlin/com/adsbynimbus/openrtb/response/DeserializationTest.kt

+2-1
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,8 @@ class DeserializationTest : StringSpec({
106106
}
107107

108108
"BidResponse fromJson deserializes use_new_renderer" {
109-
response.ext.use_new_renderer shouldBe false
109+
// if missing, default is true
110+
response.ext.use_new_renderer shouldBe true
110111
BidResponse.fromJson(testJson("""
111112
,"ext": {
112113
"use_new_renderer": true

0 commit comments

Comments
 (0)