feat: invoke onError hook when unable to parse tsconfig file

Author: thetutlage

src/dev_server.ts

@@ -16,6 +16,7 @@ import { fileURLToPath } from 'node:url'
 import { type FSWatcher } from 'chokidar'
 import { type ResultPromise } from 'execa'
 import string from '@poppinss/utils/string'
+import { RuntimeException } from '@poppinss/utils/exception'
 import { type UnWrapLazyImport } from '@poppinss/utils/types'
 
 import debug from './debug.ts'
@@ -440,6 +441,7 @@ export class DevServer {
   async start(ts: typeof tsStatic) {
     const tsConfig = parseConfig(this.cwd, ts)
     if (!tsConfig) {
+      this.#onError?.(new RuntimeException('Unable to parse tsconfig file'))
       return
     }
 
@@ -480,6 +482,7 @@ export class DevServer {
   async startAndWatch(ts: typeof tsStatic, options?: { poll: boolean }) {
     const tsConfig = parseConfig(this.cwd, ts)
     if (!tsConfig) {
+      this.#onError?.(new RuntimeException('Unable to parse tsconfig file'))
       return
     }
 

src/test_runner.ts

@@ -14,6 +14,7 @@ import { fileURLToPath } from 'node:url'
 import { type FSWatcher } from 'chokidar'
 import { type ResultPromise } from 'execa'
 import string from '@poppinss/utils/string'
+import { RuntimeException } from '@poppinss/utils/exception'
 import { type UnWrapLazyImport } from '@poppinss/utils/types'
 
 import debug from './debug.ts'
@@ -320,6 +321,7 @@ export class TestRunner {
   async runAndWatch(ts: typeof tsStatic, options?: { poll: boolean }) {
     const tsConfig = parseConfig(this.cwd, ts)
     if (!tsConfig) {
+      this.#onError?.(new RuntimeException('Unable to parse tsconfig file'))
       return
     }
 

tests/dev_server.spec.ts

@@ -13,6 +13,7 @@ import { test } from '@japa/runner'
 import { join, sep } from 'node:path'
 import { cliui } from '@poppinss/cliui'
 import { setTimeout as sleep } from 'node:timers/promises'
+import { RuntimeException } from '@poppinss/utils/exception'
 
 import { DevServer } from '../index.ts'
 
@@ -322,4 +323,52 @@ test.group('DevServer', () => {
       0
     )
   }).disableTimeout()
+
+  test('return error when tsconfig file is missing', async ({ fs, assert, cleanup }) => {
+    let hooksStack: string[] = []
+    let error: any
+
+    await fs.create(
+      'bin/server.ts',
+      `process.send({ isAdonisJS: true, environment: 'web', port: process.env.PORT, host: 'localhost' })`
+    )
+    await fs.create('.env', 'PORT=3335')
+
+    const devServer = new DevServer(fs.baseUrl, {
+      nodeArgs: [],
+      scriptArgs: [],
+      metaFiles: [],
+      suites: [],
+      hooks: {
+        devServerStarted: [
+          async () => ({
+            default: () => {
+              hooksStack.push('devServerStarted')
+            },
+          }),
+        ],
+        devServerStarting: [
+          async () => ({
+            default: () => {
+              hooksStack.push('devServerStarting')
+            },
+          }),
+        ],
+      },
+    })
+
+    devServer.ui = cliui()
+    devServer.ui.switchMode('raw')
+
+    devServer.onError((startError) => {
+      error = startError
+    })
+
+    await devServer.startAndWatch(ts)
+    cleanup(() => devServer.close())
+
+    assert.instanceOf(error, RuntimeException)
+    assert.deepEqual(devServer.ui.logger.getLogs(), [])
+    assert.deepEqual(hooksStack, [])
+  })
 })