Skip to content

Commit 4889730

Browse files
RajdeepcRajdeep ChandraRajdeep ChandraRajdeep Chandra
authored
fix(alert-dialog): added missing imports (#5669)
* fix(alert-dialog): added missed direct dependencies * fix(alert-dialog): added missed icon alert dependency * chore: added stckblitz link to dcumentation * ci: updated golden image cache * ci: updated golden image cache * ci: updated golden image cache --------- Co-authored-by: Rajdeep Chandra <[email protected]> Co-authored-by: Rajdeep Chandra <[email protected]> Co-authored-by: Rajdeep Chandra <[email protected]>
1 parent 1967a45 commit 4889730

File tree

4 files changed

+17
-4
lines changed

4 files changed

+17
-4
lines changed

.circleci/config.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ parameters:
2222
# 3. Commit this change to the PR branch where the changes exist.
2323
current_golden_images_hash:
2424
type: string
25-
default: e919c253a7cb75ee16c0ef680b50a032236f7275
25+
default: 5cb7586aae24a30d566d452d4e0b3c934fe3b9f0
2626
wireit_cache_name:
2727
type: string
2828
default: wireit

packages/alert-dialog/README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
[![See it on NPM!](https://img.shields.io/npm/v/@spectrum-web-components/alert-dialog?style=for-the-badge)](https://www.npmjs.com/package/@spectrum-web-components/alert-dialog)
88
[![How big is this package in your project?](https://img.shields.io/bundlephobia/minzip/@spectrum-web-components/alert-dialog?style=for-the-badge)](https://bundlephobia.com/result?p=@spectrum-web-components/alert-dialog)
9+
[![Try it on Stackblitz](https://img.shields.io/badge/Try%20it%20on-Stackblitz-blue?style=for-the-badge)](https://stackblitz.com/edit/vitejs-vite-1dvcjyvh)
910

1011
```bash
1112
yarn add @spectrum-web-components/alert-dialog

packages/alert-dialog/src/AlertDialog.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ import {
2020
query,
2121
} from '@spectrum-web-components/base/src/decorators.js';
2222
import '@spectrum-web-components/button/sp-button.js';
23+
import '@spectrum-web-components/button-group/sp-button-group.js';
24+
import '@spectrum-web-components/icons-workflow/icons/sp-icon-alert.js';
25+
import '@spectrum-web-components/divider/sp-divider.js';
2326
import { FocusVisiblePolyfillMixin } from '@spectrum-web-components/shared/src/focus-visible.js';
2427
import { randomID } from '@spectrum-web-components/shared/src/random-id.js';
2528
import { conditionAttributeWithId } from '@spectrum-web-components/base/src/condition-attribute-with-id.js';

packages/contextual-help/test/contextual-help.test.ts

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,18 @@ describe('ContextualHelp', () => {
3131
const button = document
3232
.querySelector('sp-contextual-help')
3333
?.shadowRoot?.querySelector('sp-action-button');
34-
expect(button).to.have.attribute('aria-label', DEFAULT_ARIA_LABELS.info);
34+
expect(button).to.have.attribute(
35+
'aria-label',
36+
DEFAULT_ARIA_LABELS.info
37+
);
3538

3639
el.variant = 'help';
3740

3841
await elementUpdated(el);
39-
expect(button).to.have.attribute('aria-label', DEFAULT_ARIA_LABELS.help);
42+
expect(button).to.have.attribute(
43+
'aria-label',
44+
DEFAULT_ARIA_LABELS.help
45+
);
4046
});
4147
it('is a popover on web', async () => {
4248
const el = await fixture<ContextualHelp>(ContextualHelpMarkup());
@@ -95,7 +101,10 @@ describe('ContextualHelp', () => {
95101

96102
const trigger = el.shadowRoot?.querySelector('#trigger') as HTMLElement;
97103
expect(trigger).to.exist;
98-
expect(trigger).to.have.attribute('aria-label', DEFAULT_ARIA_LABELS.info);
104+
expect(trigger).to.have.attribute(
105+
'aria-label',
106+
DEFAULT_ARIA_LABELS.info
107+
);
99108

100109
const overlay = el.shadowRoot?.querySelector(
101110
'sp-overlay'

0 commit comments

Comments
 (0)