Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation details #10

Open
schriftgestalt opened this issue Oct 24, 2024 · 1 comment
Open

Implementation details #10

schriftgestalt opened this issue Oct 24, 2024 · 1 comment

Comments

@schriftgestalt
Copy link

It would be nice to have some suggestions how things are supposed be implemented. Some example code with resulting ttx would be great. That would make it easier to develop consisted fea compilers.
Maybe even some unit tests we all can run our implementation agains?

@skef
Copy link
Contributor

skef commented Oct 24, 2024

We are definitely working on tests, and we are attempting to construct them so that they will work across implementations. This is new for AFDKO-related stuff, so we have to develop a bit of infrastructure.

It might be a while before those are available, however. (I can't make commitments on this, but I'm hoping it will be a matter of a couple months at most.)

I think the tests can also fill the role of implementation advice, maybe better than the alternatives. One can always run the tests with the FDK and use ttx on the output for some clarity. However, "exact" implementation advice would be counter-productive because itemVariationStore output can be optimized in various ways, and other implementations might do better on that than we do.
It will have to be a balance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants