Removing incorrect test marks

Author: adamcharnock

.pre-commit-config.yaml

@@ -1,9 +1,9 @@
 repos:
 -   repo: https://github.com/ambv/black
-    rev: master
+    rev: 23.7.0
     hooks:
     - id: black
-      args: [--line-length=100, --safe, --target-version=py38]
-      language_version: python3.7
+      args: [--line-length=100, --safe]
+      language_version: python3.11
       verbose: true
-      exclude: ^lightbus_experiments/
+      exclude: ^lightbus_(experiments|vendored)/

tests/client/test_validator_unit.py

@@ -50,7 +50,6 @@ def create_bus_client_with_unhappy_schema(validate=True, strict_validation=True)
     return create_bus_client_with_unhappy_schema
 
 
-@pytest.mark.asyncio
 def test_rpc_validate_incoming(create_bus_client_with_unhappy_schema):
     client: BusClient = create_bus_client_with_unhappy_schema()
 
@@ -60,7 +59,6 @@ def test_rpc_validate_incoming(create_bus_client_with_unhappy_schema):
     jsonschema.validate.assert_called_with({"p": 1}, {"p": {}})
 
 
-@pytest.mark.asyncio
 def test_result_validate(create_bus_client_with_unhappy_schema):
     client: BusClient = create_bus_client_with_unhappy_schema()
 
@@ -72,7 +70,6 @@ def test_result_validate(create_bus_client_with_unhappy_schema):
     jsonschema.validate.assert_called_with("123", {})
 
 
-@pytest.mark.asyncio
 def test_event_validate(create_bus_client_with_unhappy_schema):
     client: BusClient = create_bus_client_with_unhappy_schema()
 
@@ -82,15 +79,13 @@ def test_event_validate(create_bus_client_with_unhappy_schema):
     jsonschema.validate.assert_called_with({"p": 1}, {"p": {}})
 
 
-@pytest.mark.asyncio
 def test_validate_disabled(create_bus_client_with_unhappy_schema):
     client: BusClient = create_bus_client_with_unhappy_schema(validate=False)
 
     message = RpcMessage(api_name="api", procedure_name="proc", kwargs={"p": 1})
     validate_outgoing(config=client.config, schema=client.schema, message=message)
 
 
-@pytest.mark.asyncio
 def test_validate_non_strict(create_bus_client_with_unhappy_schema):
     client: BusClient = create_bus_client_with_unhappy_schema(strict_validation=False)
 
@@ -101,7 +96,6 @@ def test_validate_non_strict(create_bus_client_with_unhappy_schema):
     validate_outgoing(config=client.config, schema=client.schema, message=message)
 
 
-@pytest.mark.asyncio
 def test_validate_strict_missing_api(create_bus_client_with_unhappy_schema):
     client: BusClient = create_bus_client_with_unhappy_schema(strict_validation=True)
 
@@ -112,15 +106,13 @@ def test_validate_strict_missing_api(create_bus_client_with_unhappy_schema):
         validate_outgoing(config=client.config, schema=client.schema, message=message)
 
 
-@pytest.mark.asyncio
 def test_validate_incoming_disabled(create_bus_client_with_unhappy_schema):
     client: BusClient = create_bus_client_with_unhappy_schema(validate={"incoming": False})
 
     message = RpcMessage(api_name="api", procedure_name="proc", kwargs={"p": 1})
     validate_incoming(config=client.config, schema=client.schema, message=message)
 
 
-@pytest.mark.asyncio
 def test_validate_incoming_enabled(create_bus_client_with_unhappy_schema):
     client: BusClient = create_bus_client_with_unhappy_schema(validate={"incoming": True})
 
@@ -129,15 +121,13 @@ def test_validate_incoming_enabled(create_bus_client_with_unhappy_schema):
         validate_incoming(config=client.config, schema=client.schema, message=message)
 
 
-@pytest.mark.asyncio
 def test_validate_outgoing_disabled(create_bus_client_with_unhappy_schema):
     client: BusClient = create_bus_client_with_unhappy_schema(validate={"outgoing": False})
 
     message = RpcMessage(api_name="api", procedure_name="proc", kwargs={"p": 1})
     validate_outgoing(config=client.config, schema=client.schema, message=message)
 
 
-@pytest.mark.asyncio
 def test_validate_outgoing_enabled(create_bus_client_with_unhappy_schema):
     client: BusClient = create_bus_client_with_unhappy_schema(validate={"outgoing": True})
 

tests/plugins/test_unit_plugin_hooks.py

@@ -88,7 +88,6 @@ async def dummy_transport_consume_rpcs(*args, **kwargs):
     assert hook_tracker() == ["before_rpc_execution", "after_rpc_execution"]
 
 
-@pytest.mark.asyncio
 def test_event_sent(track_called_hooks, dummy_bus: BusPath, loop, add_base_plugin, dummy_api):
     add_base_plugin()
     dummy_bus.client.register_api(dummy_api)

tests/tests_testing.py

@@ -6,7 +6,6 @@
 from lightbus.utilities.testing import QueueMockContext
 
 
-@pytest.mark.asyncio
 def test_queue_mock_context_sync():
     queue = InternalQueue()
 

tests/transports/redis/benchmark_integration_redis.py

@@ -48,7 +48,6 @@ def bus(redis_config_file):
 
 
 @pytest.mark.benchmark(group="network")
-@pytest.mark.asyncio
 def benchmark_call_rpc(run_lightbus, bus, benchmark):
     def benchmark_me():
         assert bus.benchmark.call_me()
@@ -57,7 +56,6 @@ def benchmark_me():
 
 
 @pytest.mark.benchmark(group="network")
-@pytest.mark.asyncio
 def benchmark_fire_event(bus, benchmark):
     bus.client.register_api(BenchmarkApi())
     benchmark.pedantic(bus.benchmark.fire_me.fire, rounds=20, warmup_rounds=1)

tests/transports/test_pool.py

@@ -88,7 +88,6 @@ def run_in_many_threads_(async_fn, max_workers=50, executions=200, *args, **kwar
     return run_in_many_threads_
 
 
-@pytest.mark.asyncio
 def test_equal(dummy_pool):
     """Test the __eq__ method"""
     assert dummy_pool == TransportPool(
@@ -98,7 +97,6 @@ def test_equal(dummy_pool):
     )
 
 
-@pytest.mark.asyncio
 def test_not_equal(redis_pool, redis_server_url):
     """Test the __eq__ method"""
     assert redis_pool != TransportPool(
@@ -108,7 +106,6 @@ def test_not_equal(redis_pool, redis_server_url):
     )
 
 
-@pytest.mark.asyncio
 def test_hash_equal(dummy_pool):
     """Test the __hash__ method"""
     assert hash(dummy_pool) == hash(
@@ -120,7 +117,6 @@ def test_hash_equal(dummy_pool):
     )
 
 
-@pytest.mark.asyncio
 def test_hash_not_equal(redis_pool, redis_server_url):
     """Test the __hash__ method"""
     assert hash(redis_pool) != hash(
@@ -146,7 +142,6 @@ async def test_grow(dummy_pool: TransportPool):
     assert dummy_pool.in_use == 0
 
 
-@pytest.mark.asyncio
 def test_grow_threaded(redis_pool: TransportPool, run_in_many_threads):
     run_in_many_threads(redis_pool.grow, executions=200)