Skip to content

Remove pre 7.x compatibility from OnDiskBitmap? #10444

Open
@FoamyGuy

Description

@FoamyGuy

While looking into something else I found some libraries that have usages of pre 7.x OnDiskBitmap API that required opening the file before creating the ODB instance. I created this issue for the place I found it: adafruit/Adafruit_CircuitPython_SSD1680#34 and haven't searched for more in other libraries / learn code yet but do intend to.

In the ODB docs https://docs.circuitpython.org/en/latest/shared-bindings/displayio/index.html#displayio.OnDiskBitmap it mentions:

Older versions of CircuitPython required a file opened in binary mode. CircuitPython 7.0 modified OnDiskBitmap so that it takes a filename instead, and opens the file internally. A future version of CircuitPython will remove the ability to pass in an opened file.

But we have not yet removed that backwards functionality. Do we want to do that with 10.x?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions