Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove original Biquad type from synthio #10061

Open
jepler opened this issue Feb 13, 2025 · 2 comments
Open

Remove original Biquad type from synthio #10061

jepler opened this issue Feb 13, 2025 · 2 comments

Comments

@jepler
Copy link
Member

jepler commented Feb 13, 2025

In #9804 we deprecated the original synthio biquads in favor of the new BlockBiquads. For version 10, make the incompatible change of actually removing the old biquads.

@jepler jepler added this to the 10.0.0 milestone Feb 13, 2025
@dhalbert dhalbert assigned dhalbert and unassigned dhalbert Mar 28, 2025
@dhalbert
Copy link
Collaborator

@relic-se I started to work on this, but I'm unfamiliar with the code. Re the struct biquad_filter_state and the associated routines in synthio/Biquad.h: should these be moved to BlockBiquad, or are they completely unnecessary? The are used in audiofilters/Filter.c, synthio/Note.c etc.

Also, is the AnyBiquad type now unneeded? Are they going to be a BlockBiquad? Should we consider renaming BlockBiquad to just Biquad, deprecating BlockBiquad, and removing the old name in CPy 11?

If you have a clear idea of the changes for this issue, and could do a PR, that would be great. Thanks.

@relic-se
Copy link

I'll need to do some more digging, but I am definitely in favor of renaming BlockBiquad to Biquad. And you are correct on AnyBiquad which is just an amalgamation of the old and new classes.

I'd be happy to work on the PR here! I'll see if I can get something drafted this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants