Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audioio.AudioOut constructor accepts the same pin for both left & right channels #10003

Closed
jepler opened this issue Jan 26, 2025 · 2 comments
Closed

audioio.AudioOut constructor accepts the same pin for both left & right channels #10003

jepler opened this issue Jan 26, 2025 · 2 comments
Labels
audio bug
Milestone
9.x.x

Comments

@jepler
Copy link

jepler commented Jan 26, 2025

.. but I think it should give an error instead, possibly at the shared-bindings level.

This came up in review of #9995, which includes a special case. When fixing this, remove that code when you do.
@jepler jepler added the bug label Jan 26, 2025
@jepler jepler mentioned this issue Jan 26, 2025
Merged
@dhalbert dhalbert added the audio label Jan 26, 2025
@dhalbert dhalbert added this to the 9.x.x milestone Jan 26, 2025
@dhalbert
Copy link
Collaborator

If it would sum/mix (without overflow) the two channels, then that's useful functionality. If not, it should be an error.

@dhalbert dhalbert mentioned this issue Mar 25, 2025
Open
dhalbert added a commit to dhalbert/circuitpython that referenced this issue Mar 26, 2025
@dhalbert
Disallow identical AudioOut channel pins. Work around ESP-IDF ESP32-S…
725f8f1 
…2 bug that swaps DAC channels randomly.

- Fixes adafruit#10003.

Stumbled on espressif/esp-idf#11425 bug while testing. It
causes the left and right channels to be swapped randomly on play, which was very confusing.
Worked around by forcing a deinit/init on each play.

Also got confused because board.A0 and board.A1 are not consistently assigned to left/right
channels. Added a documentation warning about this.
@dhalbert dhalbert mentioned this issue Mar 26, 2025
Merged
@dhalbert
Copy link
Collaborator

Fixed by #10182.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
audio bug
Projects
None yet
Milestone
9.x.x
Development

No branches or pull requests
2 participants
@jepler @dhalbert