Skip to content

Commit 3d2491b

Browse files
committed
Go ahead and re-combine the two feed includes
After discussion, having an absolute URL in the generated HTML is just fine.
1 parent d7401e2 commit 3d2491b

File tree

3 files changed

+8
-15
lines changed

3 files changed

+8
-15
lines changed

_includes/downloads/board_image.html

+7-7
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
1-
{% assign small_image = "/assets/images/boards/small/" | append: include.board_image %}
2-
{% assign large_image = "/assets/images/boards/large/" | append: include.board_image %}
3-
<img srcset="{{ small_image }} 300w,
4-
{{ large_image }} 700w"
5-
sizes="(max-width: 1024px) 700px,
6-
300px"
7-
src="{{ large_image }}" alt="Image of Board" loading="lazy">
1+
{% assign small_image = "/assets/images/boards/small/" | append: include.board_image | absolute_url %}
2+
{% assign large_image = "/assets/images/boards/large/" | append: include.board_image | absolute_url %}
3+
<img srcset="{{ small_image }} 300w,
4+
{{ large_image }} 700w"
5+
sizes="(max-width: 1024px) 700px,
6+
300px"
7+
src="{{ large_image }}" alt="Image of Board" loading="lazy">

_includes/downloads/feed_board_image.html

-7
This file was deleted.

feed.html

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
<item>
1818
<title>{{ board.name }}</title>
1919
<link>{{ board.url | absolute_url }}</link>
20-
<description><![CDATA[ {% include downloads/feed_board_image.html board_image=board.board_image %}<p>By {{ board.manufacturer }}</p> {{ board.content }} ]]></description>
20+
<description><![CDATA[ {% include downloads/board_image.html board_image=board.board_image %}<p>By {{ board.manufacturer }}</p> {{ board.content }} ]]></description>
2121
{% if board.blinka %}
2222
<category>Blinka</category>
2323
{% else %}

0 commit comments

Comments
 (0)