Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundled Wire library is outdated relative to upstream Arduino core #20

Open
markmentovai opened this issue Feb 13, 2023 · 0 comments
Open

Comments

@markmentovai
Copy link

The Wire library bundled in adafruit-avr-1.4.15.tar.bz2 that’s sourced in this repository is outdated relative to the upstream Arduino core. This is a problem because, although the Adafruit AVR core delegates most things to the upstream Arduino core, the outdated Adafruit copy of the Wire library shadows the upstream’s, rendering upstream improvements invisible when targeting an Adafruit board. For example, the timeout-oriented additions from upstream aren’t available when targeting an Adafruit board. The upstream code has also received numerous bugfixes since the Adafruit fork was established.

The Adafruit Wire fork was created at c437230 (2016-01-15) to add ATtiny support according to the Wire interface presumably absent from upstream. This appears to have been forked from arduino/ArduinoCore-avr da5830c4bf62 (2015-03-26). Quite a number of changes have been made to upstream Wire since then, but aside from arduino/ArduinoCore-avr eab6601ebc4ff of 2015-08-25 and arduino/ArduinoCore-avr 7b2f6fc02881 of 2016-03-09 (both at 7157b88, 2021-11-25), it doesn’t look like any of the improvements have been brought to the Adafruit fork.

Can the local forked copy of the Wire library be synced with the updated upstream version, and ideally be kept up to date with the upstream over time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant