Merge pull request #154 from activeadmin/feature/rubocop

Introduce rubocop

Author: grzegorz-jakubiak

.gitignore

@@ -21,3 +21,4 @@ spec/reports
 /test_app/.sass-cache
 /test_app/config/mongoid.yml
 /spec/rails
+.ruby-version

.rubocop.yml

@@ -0,0 +1,104 @@
+AllCops:
+  DisabledByDefault: true
+  TargetRubyVersion: 2.4
+
+  DisplayCopNames: true
+
+  StyleGuideCopsOnly: false
+
+Layout/EndAlignment:
+  Enabled: true
+
+Lint/ParenthesesAsGroupedExpression:
+  Enabled: true
+
+Layout/AccessModifierIndentation:
+  Enabled: true
+
+Layout/CaseIndentation:
+  Enabled: true
+
+Layout/CommentIndentation:
+  Enabled: true
+
+Layout/ElseAlignment:
+  Enabled: true
+
+Layout/EmptyLines:
+  Enabled: true
+
+Layout/EmptyLinesAroundBlockBody:
+  Enabled: true
+
+Layout/EndOfLine:
+  Enabled: true
+
+Layout/ExtraSpacing:
+  Enabled: true
+
+Style/Dir:
+  Enabled: true
+
+Style/Encoding:
+  Enabled: true
+
+Style/ExpandPathArguments:
+  Enabled: true
+
+Style/FrozenStringLiteralComment:
+  Enabled: true
+  EnforcedStyle: never
+
+Style/HashSyntax:
+  Enabled: true
+
+Style/ParallelAssignment:
+  Enabled: true
+
+Layout/IndentationConsistency:
+  Enabled: true
+
+Layout/IndentationWidth:
+  Enabled: true
+
+Naming/PredicateName:
+  Enabled: true
+
+  ForbiddenPrefixes:
+    - is_
+    - have_
+
+  AllowedMethods:
+    - has_many
+    - has_many_actions
+    - is_association?
+
+Style/TrailingCommaInArguments:
+  Enabled: true
+
+Layout/TrailingEmptyLines:
+  Enabled: true
+
+Layout/TrailingWhitespace:
+  Enabled: true
+
+Layout/SpaceAfterComma:
+  Enabled: true
+
+Layout/SpaceAroundEqualsInParameterDefault:
+  Enabled: true
+
+Layout/SpaceAroundOperators:
+  Enabled: true
+
+Layout/SpaceBeforeBlockBraces:
+  Enabled: true
+
+Layout/SpaceInsideBlockBraces:
+  Enabled: true
+
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: true
+
+Layout/SpaceInsideParens:
+  Enabled: true

.travis.yml

@@ -5,6 +5,8 @@ before_install:
   - gem update --system
   - gem install bundler
   - bundle update --bundler
+after_script:
+  - bundle exec rubocop
 rvm:
   - 2.4
   - 2.5

Gemfile

@@ -20,3 +20,7 @@ group :test do
   gem 'launchy'
   gem 'simplecov', require: false
 end
+
+group :lint do
+  gem 'rubocop', '0.80.0'
+end

Gemfile.lock

@@ -74,6 +74,7 @@ GEM
     arbre (1.2.1)
       activesupport (>= 3.0.0)
     arel (9.0.0)
+    ast (2.4.0)
     bcrypt (3.1.13)
     bson (4.7.1)
     builder (3.2.3)
@@ -114,6 +115,7 @@ GEM
       has_scope (~> 0.6)
       railties (>= 5.0, < 6.1)
       responders (>= 2, < 4)
+    jaro_winkler (1.5.4)
     jquery-rails (4.3.3)
       rails-dom-testing (>= 1, < 3)
       railties (>= 4.2.0)
@@ -161,6 +163,9 @@ GEM
     nokogiri (1.10.5)
       mini_portile2 (~> 2.4.0)
     orm_adapter (0.5.0)
+    parallel (1.19.1)
+    parser (2.7.0.2)
+      ast (~> 2.4.0)
     poltergeist (1.18.1)
       capybara (>= 2.1, < 4)
       cliver (~> 0.3.1)
@@ -200,6 +205,7 @@ GEM
       method_source
       rake (>= 0.8.7)
       thor (>= 0.19.0, < 2.0)
+    rainbow (3.0.0)
     rake (12.3.3)
     ransack (2.3.2)
       activerecord (>= 5.2.1)
@@ -210,6 +216,7 @@ GEM
     responders (2.4.1)
       actionpack (>= 4.2.0, < 6.0)
       railties (>= 4.2.0, < 6.0)
+    rexml (3.2.4)
     rspec-core (3.8.0)
       rspec-support (~> 3.8.0)
     rspec-expectations (3.8.2)
@@ -227,6 +234,15 @@ GEM
       rspec-mocks (~> 3.8.0)
       rspec-support (~> 3.8.0)
     rspec-support (3.8.0)
+    rubocop (0.80.0)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.7.0.1)
+      rainbow (>= 2.2.2, < 4.0)
+      rexml
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 1.7)
+    ruby-progressbar (1.10.1)
     sass-rails (6.0.0)
       sassc-rails (~> 2.1, >= 2.1.1)
     sassc (2.2.1)
@@ -254,6 +270,7 @@ GEM
     tilt (2.0.10)
     tzinfo (1.2.5)
       thread_safe (~> 0.1)
+    unicode-display_width (1.6.1)
     warden (1.2.8)
       rack (>= 2.0.6)
     websocket-driver (0.7.0)
@@ -278,6 +295,7 @@ DEPENDENCIES
   rails (>= 5.2, < 6.1)
   ransack-mongoid!
   rspec-rails (~> 3.6)
+  rubocop (= 0.80.0)
   simplecov
 
 BUNDLED WITH

activeadmin-mongoid.gemspec

@@ -1,5 +1,4 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'active_admin/mongoid/version'
 
@@ -10,7 +9,7 @@ Gem::Specification.new do |gem|
   gem.summary       = %q{ActiveAdmin hacks to support Mongoid}
   gem.homepage      = ''
 
-  gem.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+  gem.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   gem.files         = `git ls-files`.split("\n")
   gem.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   gem.name          = 'activeadmin-mongoid'
@@ -24,7 +23,7 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency 'activeadmin', '>= 1.4.3'
   gem.add_runtime_dependency 'kaminari-mongoid'
   gem.add_runtime_dependency 'jquery-rails'
-  gem.add_runtime_dependency 'sass-rails',  ['>= 3.1.4']
+  gem.add_runtime_dependency 'sass-rails', ['>= 3.1.4']
 
-  gem.add_development_dependency 'rspec-rails',  '~> 3.6'
+  gem.add_development_dependency 'rspec-rails', '~> 3.6'
 end

lib/active_admin/mongoid/association/relatable.rb

@@ -11,4 +11,4 @@ def foreign_key
     return if embeds?
     foreign_key.to_sym rescue nil
   end
-end
+end

lib/active_admin/mongoid/controllers/resource_controller.rb

@@ -1,7 +1,6 @@
 require 'active_admin/engine'
 
 ActiveAdmin::Engine.module_eval do
-
   initializer 'active_admin.mongoid.resource_controller' do
     class ActiveAdmin::ResourceController
       def build_new_resource

lib/active_admin/mongoid/criteria.rb

@@ -19,4 +19,3 @@ def from(*a)
     end
   end
 end
-

lib/active_admin/mongoid/csv_builder.rb

@@ -11,7 +11,7 @@ def build(controller, csv)
       csv << bom if bom
 
       if column_names
-        csv << CSV.generate_line(columns.map{ |c| encode c.name, options }, csv_options)
+        csv << CSV.generate_line(columns.map { |c| encode c.name, options }, csv_options)
       end
 
       (1..paginated_collection.total_pages).each do |page|