Run rubocop

Author: grzegorz-jakubiak

.rubocop.yml

@@ -71,6 +71,7 @@ Naming/PredicateName:
   AllowedMethods:
     - has_many
     - has_many_actions
+    - is_association?
 
 Style/TrailingCommaInArguments:
   Enabled: true

activeadmin-mongoid.gemspec

@@ -1,5 +1,4 @@
-# coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'active_admin/mongoid/version'
 
@@ -10,7 +9,7 @@ Gem::Specification.new do |gem|
   gem.summary       = %q{ActiveAdmin hacks to support Mongoid}
   gem.homepage      = ''
 
-  gem.executables   = `git ls-files -- bin/*`.split("\n").map{ |f| File.basename(f) }
+  gem.executables   = `git ls-files -- bin/*`.split("\n").map { |f| File.basename(f) }
   gem.files         = `git ls-files`.split("\n")
   gem.test_files    = `git ls-files -- {test,spec,features}/*`.split("\n")
   gem.name          = 'activeadmin-mongoid'
@@ -24,7 +23,7 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency 'activeadmin', '>= 1.4.3'
   gem.add_runtime_dependency 'kaminari-mongoid'
   gem.add_runtime_dependency 'jquery-rails'
-  gem.add_runtime_dependency 'sass-rails',  ['>= 3.1.4']
+  gem.add_runtime_dependency 'sass-rails', ['>= 3.1.4']
 
-  gem.add_development_dependency 'rspec-rails',  '~> 3.6'
+  gem.add_development_dependency 'rspec-rails', '~> 3.6'
 end

lib/active_admin/mongoid/association/relatable.rb

@@ -11,4 +11,4 @@ def foreign_key
     return if embeds?
     foreign_key.to_sym rescue nil
   end
-end
+end

lib/active_admin/mongoid/controllers/resource_controller.rb

@@ -1,7 +1,6 @@
 require 'active_admin/engine'
 
 ActiveAdmin::Engine.module_eval do
-
   initializer 'active_admin.mongoid.resource_controller' do
     class ActiveAdmin::ResourceController
       def build_new_resource

lib/active_admin/mongoid/criteria.rb

@@ -19,4 +19,3 @@ def from(*a)
     end
   end
 end
-

lib/active_admin/mongoid/csv_builder.rb

@@ -11,7 +11,7 @@ def build(controller, csv)
       csv << bom if bom
 
       if column_names
-        csv << CSV.generate_line(columns.map{ |c| encode c.name, options }, csv_options)
+        csv << CSV.generate_line(columns.map { |c| encode c.name, options }, csv_options)
       end
 
       (1..paginated_collection.total_pages).each do |page|

lib/active_admin/mongoid/document.rb

@@ -3,9 +3,6 @@
 module ActiveAdmin::Mongoid::Document
   extend ActiveSupport::Concern
 
-
-
-
   # PROXY CLASSES
 
   class ColumnWrapper < SimpleDelegator
@@ -30,9 +27,6 @@ def quote_column_name name
     end
   end
 
-
-
-
   # CLASS METHODS
 
   included do
@@ -47,7 +41,6 @@ class << self
     def column_for_attribute(name)
       self.class.fields[name.to_sym]
     end
-
   end
 
   module ClassMethods
@@ -63,7 +56,7 @@ def connection
     end
 
     def find_by_id id
-      find_by(:_id => id)
+      find_by(_id: id)
     end
 
     def quoted_table_name
@@ -74,7 +67,6 @@ def associations
       @associations ||= new.associations
     end
 
-
     def reflections *a
       relations *a
     end

lib/active_admin/mongoid/filter_form_builder.rb

@@ -9,11 +9,11 @@ def filter(method, options = {})
   def default_input_type(method, options = {})
     if column = column_for(method)
       case column.type.name.downcase.to_sym
-      when :date, :datetime, :time;   :date_range
-      when :string, :text, :object;  :string
-      when :float, :decimal;          :numeric
+      when :date, :datetime, :time; :date_range
+      when :string, :text, :object; :string
+      when :float, :decimal; :numeric
       when :integer
-        return :select if reflection_for(method.to_s.gsub('_id','').to_sym)
+        return :select if reflection_for(method.to_s.gsub('_id', '').to_sym)
         return :numeric
       end
     elsif is_association?(method)

lib/active_admin/mongoid/filters/resource_extension.rb

@@ -4,7 +4,7 @@ module ActiveAdmin::Filters::ResourceExtension
   def default_association_filters
     if resource_class.respond_to?(:reflect_on_all_associations)
       without_embedded = resource_class.reflect_on_all_associations.reject { |e| e.embeds? }
-      poly, not_poly = without_embedded.partition{ |r| r.macro == :belongs_to && r.options[:polymorphic] }
+      poly, not_poly = without_embedded.partition { |r| r.macro == :belongs_to && r.options[:polymorphic] }
 
       filters = poly.map(&:foreign_key) + not_poly.map(&:name)
       filters.map &:to_sym

lib/active_admin/mongoid/resource.rb

@@ -6,7 +6,7 @@ class Resource
     #  another.  I'm not going to investigate any deeper, let's just remove the
     #  underscore prefixed fields as was the prior behavior
     def default_filters
-      super.reject { |filter|  filter == :_id }
+      super.reject { |filter| filter == :_id }
     end
 
     module Attributes

lib/active_admin/mongoid/resource/attributes.rb

@@ -6,8 +6,8 @@ class Resource
     module Attributes
       def foreign_methods
         @foreign_methods ||= resource_class.reflect_on_all_associations.
-          select{ |r| r.macro == :belongs_to }.
-          index_by{ |r| r.foreign_key.to_sym }
+          select { |r| r.macro == :belongs_to }.
+          index_by { |r| r.foreign_key.to_sym }
       end
 
       def primary_col?(c)
@@ -20,4 +20,3 @@ def sti_col?(c)
     end
   end
 end
-

lib/meta_search/searches/mongoid.rb

@@ -10,7 +10,8 @@ class MongoidSearchBuilder < SimpleDelegator
       def initialize relation, params, options
         super(relation)
         @relation = relation
-        @params, @options = params, options
+        @params = params
+        @options = options
       end
 
       def build
@@ -78,7 +79,6 @@ def method_missing name, *attrs, &block
         relation.send(name, *attrs, &block)
       end
 
-
       def respond_to? name, include_private = false
         name.to_s =~ metasearch_regexp or super
       end
@@ -92,8 +92,8 @@ def method_missing name, *args, &block
       end
 
       def metasearch_regexp
-        field_names = klass.fields.map{ |field| field.second.name }
-        conditions = MetaSearch::DEFAULT_WHERES.map {|condition| condition[0...-1]} # pop tail options
+        field_names = klass.fields.map { |field| field.second.name }
+        conditions = MetaSearch::DEFAULT_WHERES.map { |condition| condition[0...-1] } # pop tail options
 
         /\A(#{field_names.join('|')})_(#{conditions.join('|')})\z/
       end

spec/features/smoke_spec.rb

@@ -1,4 +1,3 @@
-# coding: utf-8
 require 'spec_helper'
 
 describe 'browse the test app' do
@@ -66,7 +65,6 @@
     end
 
     context 'with 1 post' do
-
       before do
         Post.create!(title: 'Quick Brown Fox', body: 'The quick brown fox jumps over the lazy dog.', view_count: 5, admin_user: admin_user, other_user: other_user)
 
@@ -232,7 +230,7 @@
             Post.where(body: 'The quick brown fox jumps over the lazy dog.').update_all(author: { name: 'Bob', city: { name: 'Washington' } })
             post.author = Author.new name: 'Adam', city: { name: 'California' }
             post.save!
-            Post.all.each{|p| p.author.city }
+            Post.all.each { |p| p.author.city }
           end
 
           it 'sorts by the embedded document field' do
@@ -275,7 +273,7 @@
             display_total_text = I18n.t 'active_admin.pagination.multiple',
                                         model: 'Posts', total: posts_size,
                                         from: offset + 1, to: offset + collection_size
-            display_total_text     = Nokogiri::HTML(display_total_text).text.gsub(' ', ' ')
+            display_total_text = Nokogiri::HTML(display_total_text).text.gsub(' ', ' ')
             pagination_information = page.find('.pagination_information').text
             expect(pagination_information).to include(display_total_text)
           end
@@ -316,8 +314,6 @@
         visit '/admin/admin_users.csv'
         expect(page.status_code).to eq(200) or eq(304)
       end
-
-
     end
   end
 end

spec/lib/active_admin/mongoid/filter_form_builder_spec.rb

@@ -60,11 +60,9 @@
       it { is_expected.to eq :string }
     end
 
-
-  # when :date, :datetime, :time;   :date_range
-  # when :string, :text, :object;  :string
-  # when :float, :decimal;          :numeric
-  # when :integer
-
+    # when :date, :datetime, :time;   :date_range
+    # when :string, :text, :object;  :string
+    # when :float, :decimal;          :numeric
+    # when :integer
   end
 end

spec/spec_helper.rb

@@ -11,13 +11,13 @@
   end
 end
 
-require File.expand_path("../../test_app/config/environment", __FILE__)
+require File.expand_path('../test_app/config/environment', __dir__)
 require 'rspec/rails'
 
 # Requires supporting ruby files with custom matchers and macros, etc,
 # in spec/support/ and its subdirectories.
-Dir[File.join(File.expand_path("../../", __FILE__), "spec/support/**/*.rb")].each {|f| require f}
-Dir[Rails.root.join("spec/support/**/*.rb")].each {|f| require f}
+Dir[File.join(File.expand_path('..', __dir__), "spec/support/**/*.rb")].each { |f| require f }
+Dir[Rails.root.join("spec/support/**/*.rb")].each { |f| require f }
 
 RSpec.configure do |config|
   # ## Mock Framework

spec/support/debug.rb

@@ -1,3 +1,3 @@
-def debugit( *args, &block )
-  it( *args, { driver: :poltergeist_debug, inspector: true }, &block )
+def debugit(*args, &block)
+  it(*args, { driver: :poltergeist_debug, inspector: true }, &block)
 end

spec/support/mongoid.rb

@@ -1,11 +1,11 @@
 require 'pathname'
 require 'mongoid'
-root    = Pathname(File.expand_path('../../../test_app', __FILE__))
+root    = Pathname(File.expand_path('../../test_app', __dir__))
 version = Mongoid::VERSION.to_i
 
 current_config = root.join("config/mongoid.#{version}.yml").read
 config_file    = root.join('config/mongoid.yml')
-config_file.open('w') {|c| c << current_config }
+config_file.open('w') { |c| c << current_config }
 
 Mongoid.load!(config_file, :test)
 Mongo::Logger.logger.level = ::Logger::FATAL

tasks/js.rake

@@ -1,5 +1,4 @@
 namespace :js do
-
   desc "Compile the JS for Rails apps without Asset Pipeline"
   task :compile do
     require 'sprockets'
@@ -28,5 +27,4 @@ namespace :js do
 
     FileUtils.mv tmp_base_js, base_js
   end
-
 end

tasks/test.rake

@@ -7,10 +7,9 @@ end
 
 # Run specs and cukes
 desc "Run the full suite"
-task :test => ['spec:unit', 'spec:integration']
+task test: ['spec:unit', 'spec:integration']
 
 namespace :test do
-
   def run_tests_against(*versions)
     current_version = detect_rails_version if File.exists?("Gemfile.lock")
 
@@ -33,16 +32,14 @@ namespace :test do
   end
 
   desc "Alias for major_supported_rails"
-  task :all => :major_supported_rails
-
+  task all: :major_supported_rails
 end
 
 require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
 namespace :spec do
-
   desc "Run the unit specs"
   RSpec::Core::RakeTask.new(:unit) do |t|
     t.pattern = "spec/unit/**/*_spec.rb"
@@ -52,7 +49,6 @@ namespace :spec do
   RSpec::Core::RakeTask.new(:integration) do |t|
     t.pattern = "spec/integration/**/*_spec.rb"
   end
-
 end
 
 #

test_app/Rakefile

@@ -2,6 +2,6 @@
 # Add your own tasks in files placed in lib/tasks ending in .rake,
 # for example lib/tasks/capistrano.rake, and they will automatically be available to Rake.
 
-require File.expand_path('../config/application', __FILE__)
+require File.expand_path('config/application', __dir__)
 
 TestApp::Application.load_tasks

test_app/app/admin/dashboard.rb

@@ -1,10 +1,9 @@
 ActiveAdmin.register_page "Dashboard" do
+  menu priority: 1, label: proc { I18n.t("active_admin.dashboard") }
 
-  menu :priority => 1, :label => proc{ I18n.t("active_admin.dashboard") }
-
-  content :title => proc{ I18n.t("active_admin.dashboard") } do
-    div :class => "blank_slate_container", :id => "dashboard_default_message" do
-      span :class => "blank_slate" do
+  content title: proc { I18n.t("active_admin.dashboard") } do
+    div class: "blank_slate_container", id: "dashboard_default_message" do
+      span class: "blank_slate" do
         span I18n.t("active_admin.dashboard_welcome.welcome")
         small I18n.t("active_admin.dashboard_welcome.call_to_action")
       end

test_app/app/admin/posts.rb

@@ -10,7 +10,6 @@
   filter :admin_user, as: :select
   filter :other_user, as: :check_boxes
 
-
   index do
     selectable_column
     column :title

test_app/app/models/admin_user.rb

@@ -7,25 +7,25 @@ class AdminUser
          :recoverable, :rememberable, :trackable, :validatable
 
   ## Database authenticatable
-  field :email,              :type => String, :default => ""
-  field :encrypted_password, :type => String, :default => ""
+  field :email,              type: String, default: ""
+  field :encrypted_password, type: String, default: ""
 
   ## Recoverable
-  field :reset_password_token,   :type => String
-  field :reset_password_sent_at, :type => Time
+  field :reset_password_token,   type: String
+  field :reset_password_sent_at, type: Time
 
   ## Rememberable
-  field :remember_created_at, :type => Time
+  field :remember_created_at, type: Time
 
   ## Trackable
-  field :sign_in_count,      :type => Integer, :default => 0
-  field :current_sign_in_at, :type => Time
-  field :last_sign_in_at,    :type => Time
-  field :current_sign_in_ip, :type => String
-  field :last_sign_in_ip,    :type => String
+  field :sign_in_count,      type: Integer, default: 0
+  field :current_sign_in_at, type: Time
+  field :last_sign_in_at,    type: Time
+  field :current_sign_in_ip, type: String
+  field :last_sign_in_ip,    type: String
 
   has_many :posts
-  
+
   def name
     email
   end