fix #756 reverse job does not support encryption mode

Author: LordofAvernus

drivers/api/handler/v2/job.go

@@ -1549,20 +1549,29 @@ func ReverseJob(c echo.Context) error {
 			reverseJobParam.SrcTask.MysqlConnectionConfig.MysqlPassword = reqParam.ReverseConfig.SrcPwd
 			reverseJobParam.DestTask.MysqlConnectionConfig.MysqlUser = reqParam.ReverseConfig.DestUser
 			reverseJobParam.DestTask.MysqlConnectionConfig.MysqlPassword = reqParam.ReverseConfig.DstPwd
-			reverseJobParam.IsMysqlPasswordEncrypted = reqParam.ReverseConfig.IsMysqlPasswordEncrypted
 		}
 		reverseJobParam.Retry = originalJob.BasicTaskProfile.Configuration.RetryTimes
 
+		// IsMysqlPasswordEncrypted is set to default false then decrypt pwd
+		if reqParam.ReverseConfig.IsMysqlPasswordEncrypted {
+			err := decryptPwd(reverseJobParam.SrcTask, reverseJobParam.DestTask)
+			if nil != err {
+				return c.JSON(http.StatusInternalServerError, models.BuildBaseResp(err))
+			}
+			reverseJobParam.IsMysqlPasswordEncrypted = false
+		}
 		// validate job
 		validationTasks, err := validateTaskConfig(reverseJobParam.SrcTask, reverseJobParam.DestTask)
 		if nil != err {
 			return c.JSON(http.StatusInternalServerError, models.BuildBaseResp(fmt.Errorf("validate task config failed: %v", err)))
 		}
 		for i := range validationTasks {
-			if validationTasks[i].PrivilegesValidation.Error != "" ||
-				validationTasks[i].ConnectionValidation.Error != "" {
+			if validationTasks[i].ConnectionValidation.Error != "" {
 				return c.JSON(http.StatusInternalServerError, models.BuildBaseResp(fmt.Errorf("validate task config fail,check Mysql connection info")))
 			}
+			if validationTasks[i].PrivilegesValidation.Error != "" {
+				return c.JSON(http.StatusInternalServerError, models.BuildBaseResp(fmt.Errorf("validate task config fail,check Mysql privileges info")))
+			}
 		}
 
 		user, err := getCurrentUser(c)

drivers/api/handler/v2/validation.go

@@ -50,13 +50,9 @@ func ValidateJobV2(c echo.Context) error {
 	logger.Info("validate task config")
 	// decrypt mysql password
 	if jobConfig.IsMysqlPasswordEncrypted {
-		jobConfig.SrcTaskConfig.MysqlConnectionConfig.MysqlPassword, err = handler.DecryptMysqlPassword(jobConfig.SrcTaskConfig.MysqlConnectionConfig.MysqlPassword, g.RsaPrivateKey)
+		err := decryptPwd(jobConfig.SrcTaskConfig, jobConfig.DestTaskConfig)
 		if nil != err {
-			return c.JSON(http.StatusInternalServerError, models.BuildBaseResp(fmt.Errorf("decrypt src mysql password failed: %v", err)))
-		}
-		jobConfig.DestTaskConfig.MysqlConnectionConfig.MysqlPassword, err = handler.DecryptMysqlPassword(jobConfig.DestTaskConfig.MysqlConnectionConfig.MysqlPassword, g.RsaPrivateKey)
-		if nil != err {
-			return c.JSON(http.StatusInternalServerError, models.BuildBaseResp(fmt.Errorf("decrypt src mysql password failed: %v", err)))
+			return c.JSON(http.StatusInternalServerError, models.BuildBaseResp(err))
 		}
 	}
 
@@ -91,6 +87,19 @@ func apiJobConfigToNomadJobJson(apiJobConfig *models.ValidateJobReqV2) (resJson
 	return resJson, nil
 }
 
+func decryptPwd(apiSrcTask *models.MysqlSrcTaskConfig, apiDestTask *models.MysqlDestTaskConfig) (err error) {
+	// decrypt mysql password
+	apiSrcTask.MysqlConnectionConfig.MysqlPassword, err = handler.DecryptMysqlPassword(apiSrcTask.MysqlConnectionConfig.MysqlPassword, g.RsaPrivateKey)
+	if nil != err {
+		return fmt.Errorf("decrypt src mysql password failed: %v", err)
+	}
+	apiDestTask.MysqlConnectionConfig.MysqlPassword, err = handler.DecryptMysqlPassword(apiDestTask.MysqlConnectionConfig.MysqlPassword, g.RsaPrivateKey)
+	if nil != err {
+		return fmt.Errorf("decrypt src mysql password failed: %v", err)
+	}
+	return
+}
+
 func validateTaskConfig(apiSrcTask *models.MysqlSrcTaskConfig, apiDestTask *models.MysqlDestTaskConfig) ([]*models.MysqlTaskValidationReport, error) {
 	taskValidationRes := []*models.MysqlTaskValidationReport{}
 	// validate src task