-
Notifications
You must be signed in to change notification settings - Fork 134
Closed as not planned
Labels
Description
Describe the bug
This statement in documentation is not true: When warn-only is set to true, all vulnerabilities, independently of the severity, will be reported as warnings and the action will not fail. The vulnerabilities are reported as warnings but the job fails
To Reproduce
Steps to reproduce the behavior:
- Having previously configured dependency review as follows:
uses: actions/dependency-review-action@v4
with:
comment-summary-in-pr: always
fail-on-severity: high
deny-licenses: GPL-1.0-or-later, LGPL-2.0-or-later
warn-only: true
base-ref: ${{ github.event.pull_request.base.sha || 'main' }}
head-ref: ${{ github.event.pull_request.head.sha || github.ref }} - Define a pom with this dependency:
org.apache.tomcat.embed
tomcat-embed-core
10.1.24
provided
- Create a PR to upload changes in pom
- Wait until dependency review finishes
- See that the vulnerability is correctly detected as a warning but the job fails
Expected behavior
The job ought not to fail
Action version
v4
Examples
https://github.com/dolorsfg/spring-demo/actions/runs/10593485619/job/29355095706?pr=1