Skip to content

Rust flags should not be overwritten by default #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xermicus opened this issue Feb 27, 2025 · 2 comments
Closed

Rust flags should not be overwritten by default #54

xermicus opened this issue Feb 27, 2025 · 2 comments

Comments

@xermicus
Copy link

xermicus commented Feb 27, 2025

Set the value of RUSTFLAGS (set to empty string to avoid overwriting existing flags)

Why do people have to set it to an empty string to not overwrite them? That doesn't follow to me; instead what seems obvious to me would be to not touch the rust flags if rustflags is omitted, and, well, just set them to whatever the value of rustflags is if it was specified.

@athei
Copy link

athei commented Feb 27, 2025

Strongly agree. The default should not override pre-existing flags. For example, it is customary to set architecture specific flags in config.toml that are required to build a project.

@jonasbb
Copy link
Member

jonasbb commented Feb 27, 2025

The topic is already discussed here #48

@jonasbb jonasbb closed this as completed Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants