Skip to content

Commit d99efa8

Browse files
committed
STAN fixes
1 parent 4f67cd9 commit d99efa8

File tree

3 files changed

+18
-6
lines changed

3 files changed

+18
-6
lines changed

Tests/Unit/Mailer/Factory/SparkpostTransportFactoryTest.php

+10-6
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
namespace MauticPlugin\SparkpostBundle\Tests\Unit\Mailer\Factory;
66

7+
use Mautic\CoreBundle\Helper\CoreParametersHelper;
78
use Mautic\EmailBundle\Model\TransportCallback;
89
use MauticPlugin\SparkpostBundle\Mailer\Factory\SparkpostTransportFactory;
910
use MauticPlugin\SparkpostBundle\Mailer\Transport\SparkpostTransport;
@@ -22,19 +23,22 @@ class SparkpostTransportFactoryTest extends TestCase
2223
{
2324
private SparkpostTransportFactory $sparkpostTransportFactory;
2425

25-
private TranslatorInterface|MockObject $translatorMock;
26+
private TranslatorInterface&MockObject $translatorMock;
27+
private CoreParametersHelper&MockObject $coreParametersHelper;
2628

2729
protected function setUp(): void
2830
{
29-
$eventDispatcherMock = $this->createMock(EventDispatcherInterface::class);
30-
$this->translatorMock = $this->createMock(TranslatorInterface::class);
31-
$transportCallbackMock = $this->createMock(TransportCallback::class);
32-
$httpClientMock = $this->createMock(HttpClientInterface::class);
33-
$loggerMock = $this->createMock(LoggerInterface::class);
31+
$eventDispatcherMock = $this->createMock(EventDispatcherInterface::class);
32+
$this->translatorMock = $this->createMock(TranslatorInterface::class);
33+
$transportCallbackMock = $this->createMock(TransportCallback::class);
34+
$this->coreParametersHelper = $this->createMock(CoreParametersHelper::class);
35+
$httpClientMock = $this->createMock(HttpClientInterface::class);
36+
$loggerMock = $this->createMock(LoggerInterface::class);
3437

3538
$this->sparkpostTransportFactory = new SparkpostTransportFactory(
3639
$transportCallbackMock,
3740
$this->translatorMock,
41+
$this->coreParametersHelper,
3842
$eventDispatcherMock,
3943
$httpClientMock,
4044
$loggerMock

Tests/Unit/Mailer/Transport/SparkpostTransportMessageTest.php

+3
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
namespace MauticPlugin\SparkpostBundle\Tests\Unit\Mailer\Transport;
66

7+
use Mautic\CoreBundle\Helper\CoreParametersHelper;
78
use Mautic\EmailBundle\Mailer\Message\MauticMessage;
89
use Mautic\EmailBundle\Model\TransportCallback;
910
use MauticPlugin\SparkpostBundle\Mailer\Transport\SparkpostTransport;
@@ -27,13 +28,15 @@ public function testCcAndBccFields(): void
2728

2829
$transportCallbackMock = $this->createMock(TransportCallback::class);
2930
$httpClientMock = $this->createMock(HttpClientInterface::class);
31+
$coreParametersHelper = $this->createMock(CoreParametersHelper::class);
3032
$eventDispatcherMock = $this->createMock(EventDispatcherInterface::class);
3133
$loggerMock = $this->createMock(LoggerInterface::class);
3234

3335
$sparkpost = new SparkpostTransport(
3436
'1234',
3537
'us',
3638
$transportCallbackMock,
39+
$coreParametersHelper,
3740
$httpClientMock,
3841
$eventDispatcherMock,
3942
$loggerMock

Tests/Unit/Mailer/Transport/SparkpostTransportTest.php

+5
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,7 @@
44

55
namespace MauticPlugin\SparkpostBundle\Tests\Unit\Mailer\Transport;
66

7+
use Mautic\CoreBundle\Helper\CoreParametersHelper;
78
use Mautic\EmailBundle\Mailer\Message\MauticMessage;
89
use Mautic\EmailBundle\Model\TransportCallback;
910
use MauticPlugin\SparkpostBundle\Mailer\Transport\SparkpostTransport;
@@ -23,6 +24,8 @@ class SparkpostTransportTest extends TestCase
2324
{
2425
private TransportCallback|MockObject $transportCallbackMock;
2526

27+
private CoreParametersHelper&MockObject $coreParametersHelper;
28+
2629
private HttpClientInterface|MockObject $httpClientMock;
2730

2831
private EventDispatcherInterface|MockObject $eventDispatcherMock;
@@ -34,13 +37,15 @@ class SparkpostTransportTest extends TestCase
3437
protected function setUp(): void
3538
{
3639
$this->transportCallbackMock = $this->createMock(TransportCallback::class);
40+
$this->coreParametersHelper = $this->createMock(CoreParametersHelper::class);
3741
$this->httpClientMock = $this->createMock(HttpClientInterface::class);
3842
$this->eventDispatcherMock = $this->createMock(EventDispatcherInterface::class);
3943
$this->loggerMock = $this->createMock(LoggerInterface::class);
4044
$this->transport = new SparkpostTransport(
4145
'api-key',
4246
'some-region',
4347
$this->transportCallbackMock,
48+
$this->coreParametersHelper,
4449
$this->httpClientMock,
4550
$this->eventDispatcherMock,
4651
$this->loggerMock

0 commit comments

Comments
 (0)