ACMS-4504: Remove the unused code from all tests.

Author: rajeshreeputra

modules/acquia_cms_headless/tests/src/Functional/DashboardApiUsersTest.php

@@ -59,7 +59,7 @@ public function testSection(): void {
     $this->assertButtonLink($usersFieldset, '/admin/people/create?destination=/admin/headless/dashboard');
 
     // Test table body exists and has data in the same order.
-    $this->assertEquals('Headless', $this->getTableBodyColumn(0,1)->getText());
+    $this->assertEquals('Headless', $this->getTableBodyColumn(0, 1)->getText());
     $this->assertEquals('Headless Administrator', $this->getTableBodyColumn(1)->getText());
 
     // Get the API Users operations dropdown elements.

modules/acquia_cms_headless/tests/src/Functional/HeadlessContentTest.php

@@ -30,21 +30,6 @@ class HeadlessContentTest extends WebDriverTestBase {
     'media_library',
   ];
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Scheduler has a config schema errors, and until it's fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */
@@ -118,8 +103,6 @@ public function testContentAdmin(): void {
     /** @var \Drupal\FunctionalJavascriptTests\JSWebAssert $assertSession */
     $assertSession = $this->assertSession();
     $assertSession->pageTextContains('Headless Test Page');
-    // @todo Below commented test is failing in 3.0-rc8 version of Gin theme.
-    // However this was working in 3.0-rc5 will be fixed in ACMS-3456.
     $assertSession->linkNotExists('View');
     $nodePageMenus = [
     'API' => '/jsonapi/node/test/' . $node->uuid(),

modules/acquia_cms_headless/tests/src/Functional/HeadlessDrushCommandsTest.php

@@ -29,21 +29,6 @@ class HeadlessDrushCommandsTest extends BrowserTestBase {
    */
   protected $defaultTheme = 'stark';
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Scheduler has a config schema errors, and until it's fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */

modules/acquia_cms_headless/tests/src/Functional/HeadlessFrontpageTest.php

@@ -3,7 +3,6 @@
 namespace Drupal\Tests\acquia_cms_headless\Functional;
 
 use Drupal\Tests\BrowserTestBase;
-use Drupal\user\Entity\Role;
 
 /**
  * Tests for acquia_cms_headless frontpage.
@@ -23,25 +22,9 @@ class HeadlessFrontpageTest extends BrowserTestBase {
    */
   protected static $modules = [
     'acquia_cms_headless_ui',
-    'node',
     'views',
   ];
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Scheduler has a config schema errors, and until it's fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * Assert that frontpage for non logged-in user is login page.
    */
@@ -56,15 +39,6 @@ public function testFrontPageIsLoginPage(): void {
    */
   public function testFrontPageIsAdminContentPage(): void {
     $account = $this->createUser();
-    // Ensure the administrator role exists,
-    // required for local environment tests with ddev.
-    if (!Role::load('administrator')) {
-      Role::create([
-        'id' => 'administrator',
-        'label' => 'Administrator',
-        'is_admin' => TRUE,
-      ])->save();
-    }
     $account->addRole('administrator');
     $account->save();
     // Don't use one-time login links instead submit the login form.

modules/acquia_cms_headless/tests/src/Functional/HeadlessModeEnablementTest.php

@@ -3,7 +3,6 @@
 namespace Drupal\Tests\acquia_cms_headless\Functional;
 
 use Drupal\Core\Extension\Exception\UnknownExtensionException;
-use Drupal\user\Entity\Role;
 
 /**
  * Tests for acquia_cms_headless Hybrid mode.

modules/acquia_cms_headless/tests/src/Functional/HeadlessSubrequestsTest.php

@@ -25,21 +25,6 @@ class HeadlessSubrequestsTest extends BrowserTestBase {
     'acquia_cms_headless',
   ];
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Scheduler has a config schema errors, and until it's fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */

modules/acquia_cms_headless/tests/src/Functional/HeadlessTestBase.php

@@ -4,7 +4,6 @@
 
 use Acquia\DrupalEnvironmentDetector\AcquiaDrupalEnvironmentDetector;
 use Drupal\FunctionalJavascriptTests\WebDriverTestBase;
-use Drupal\user\Entity\Role;
 
 /**
  * Base class for the HeadlessDashboard web_driver tests.
@@ -22,23 +21,9 @@ abstract class HeadlessTestBase extends WebDriverTestBase {
   protected static $modules = [
     'acquia_cms_headless',
     'entity_clone',
+    'views'
   ];
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Scheduler has a config schema errors, and until it's fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * {@inheritdoc}
    */
@@ -54,6 +39,10 @@ protected function setUp(): void {
     $account->save();
     $this->drupalLogin($account);
 
+    // Place the tasks and page title blocks.
+    $this->drupalPlaceBlock('local_tasks_block', ['id' => 'local-tasks', 'region' => 'content', 'theme' => 'stark']);
+    $this->drupalPlaceBlock('page_title_block', ['id' => 'page-title', 'region' => 'content', 'theme' => 'stark']);
+
     // Visit headless dashboard.
     $this->drupalGet("/admin/headless/dashboard");
   }

modules/acquia_cms_headless/tests/src/Functional/PureHeadlessModeMenuTest.php

@@ -7,7 +7,6 @@
 use Drupal\Core\Extension\Exception\UnknownExtensionException;
 use Drupal\Core\Extension\ModuleExtensionList;
 use Drupal\FunctionalJavascriptTests\WebDriverTestBase;
-use Drupal\user\Entity\Role;
 
 /**
  * Pure headless mode menu tests.
@@ -31,26 +30,12 @@ class PureHeadlessModeMenuTest extends WebDriverTestBase {
    */
   protected static $modules = [
     'acquia_cms_headless_ui',
+    'acquia_cms_toolbar',
     'block_content',
     'media_library',
     'menu_ui',
   ];
 
-  /**
-   * Disable strict config schema checks in this test.
-   *
-   * Scheduler has a config schema errors, and until it's fixed,
-   * this test cannot pass unless we disable strict config schema checking
-   * altogether. Since strict config schema isn't critically important in
-   * testing this functionality, it's okay to disable it for now, but it should
-   * be re-enabled (i.e., this property should be removed) as soon as possible.
-   *
-   * @var bool
-   */
-  // @codingStandardsIgnoreStart
-  protected $strictConfigSchema = FALSE;
-  // @codingStandardsIgnoreEnd
-
   /**
    * The module installer object.
    *
@@ -78,15 +63,6 @@ protected function setUp(): void {
     $this->moduleInstaller = $this->container->get('module_installer');
     $this->moduleList = $this->container->get('extension.list.module');
     $account = $this->drupalCreateUser();
-    // Ensure the administrator role exists,
-    // required for local environment tests with ddev.
-    if (!Role::load('administrator')) {
-      Role::create([
-        'id' => 'administrator',
-        'label' => 'Administrator',
-        'is_admin' => TRUE,
-      ])->save();
-    }
     $account->addRole('administrator');
     $account->save();
     $this->drupalLogin($account);

modules/acquia_cms_headless/tests/src/Traits/DashboardSectionTrait.php

@@ -3,7 +3,6 @@
 namespace Drupal\Tests\acquia_cms_headless\Traits;
 
 use Behat\Mink\Element\NodeElement;
-use Drupal\user\Entity\Role;
 
 /**
  * Trait to test dashboard section.