Skip to content

Conversation

@aaditn
Copy link

@aaditn aaditn commented Feb 5, 2025

Marking dashboard config variables if they've been changed from their uploaded value.

Marking dashboard config variables if they've been changed from them from their uploaded value
@rbrott
Copy link
Member

rbrott commented Feb 16, 2025

Thanks for the patch!

Marking dashboard config variables if they've been changed from their uploaded value.

I take the uploaded value to mean the value that was in the file deployed to the bot. The client needs more information from the backend to provide that value and shouldn't assume that the first config received by the client contains the deployed values.

Also you should use yarn format to format client changes. It's also great for graphical changes if you can post a screenshot of the new UI.

mxtmx and others added 6 commits April 27, 2025 12:46
Introduces backend and frontend support for tracking baseline configuration values as deployed to the robot. Adds new message types and Redux state for baseline config, updates the UI to display and filter variables modified from the baseline, and provides visual indicators for such modifications. This helps users identify and manage configuration changes relative to the deployed baseline.
@mxtmx
Copy link
Contributor

mxtmx commented Aug 22, 2025

Thanks, that makes a lot of sense; I've updated the code to take the deployed value from the backend.

Note: this update converts the parentheses to the right of float variables to show the deployed value instead. I assumed the original purpose of the parentheses wasn't necessary, but let me know if you would like me to keep it, and I can change the UI accordingly.

FYI, this PR would resolve #50.

Screen.Recording.2025-08-22.at.11.26.22.AM.mov

@mxtmx
Copy link
Contributor

mxtmx commented Sep 1, 2025

Merge conflicts have been resolved

@rbrott
Copy link
Member

rbrott commented Sep 13, 2025

Thanks for updating and including a video. The red exclamation point strikes me as a bit extreme for a pretty common, nominal situation when using config variables. What do you think about softening it to a bullet point in yellow?

I'm pretty happy with this
image
which is in text-yellow-600.

I also like it combined with the unsaved indicator in the same slot (I used display: inline-block; text-align: center; width: 1ch to keep things from shifting around) and making the unsaved indicator bubble up as well.

@mxtmx
Copy link
Contributor

mxtmx commented Nov 1, 2025

Sorry for the delay, just fixed!

@rbrott
Copy link
Member

rbrott commented Dec 1, 2025

I just test-drove this PR in its current state.

  • The unsaved indicator doesn't bubble up like the changed-from-deployed indicator. I mostly want parity here. I'm fine if neither or both bubble up so long as it's consistent.
  • The unsaved indicator should override the changed-from-deployed indicator. If a field is both unsaved and the previously saved field was changed from deployed it should just show as unsaved.
  • Small copy change: "Modified from deployed baseline" -> "Changed from last deployed value"
  • Small nit: The different spacing between the two dots here bothers me:
    image
    It would be great if the "More Primitives" dot was closer to the text to match the dot near "Float." (And I like how "Float" doesn't move when the dot is added/removed unlike "More Primitives.")

This is close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants