Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npmjs version 0.24.0 is not the version contained in this repository #811

Open
rmlearney-digicatapult opened this issue Jan 6, 2025 · 3 comments

Comments

@rmlearney-digicatapult
Copy link

rmlearney-digicatapult commented Jan 6, 2025

Bug Report 🐛

Trying to reconstruct a template programmatically in Javascript:

  const { Template, Clause } = require("@accordproject/cicero-core");

Fails with version-respecting .cto files (now required in 0.24.0) because it looks for the file loader from ergo-compiler.

Examining the templateloader.js file in node_modules/@accordproject/cicero-core/lib/templateloader.js the following can be seen in lines 26 and 27.

var Logger = require('@accordproject/ergo-compiler').Logger;
var FileLoader = require('@accordproject/ergo-compiler').FileLoader;

This templateloader.js file is not the same templateloader.js that exists in this repo under src/templateloader.js

My package.json contains "@accordproject/cicero-core": "^0.24.0", as a dependency

Expected Behavior

Should load files without using ergo-compiler's template loader

Current Behavior

Fails

Possible Solution

Update npmjs with version in this repo

Steps to Reproduce

Context (Environment)

Desktop

  • MacOS
  • Browser: [e.g. Chrome, Safari]
  • Version: 0.24.0

Detailed Description

Possible Implementation

@rmlearney-digicatapult rmlearney-digicatapult changed the title npm version 0.24.0 contains code that is no longer in this repository npmjs version 0.24.0 contains code that is no longer in this repository Jan 6, 2025
@rmlearney-digicatapult rmlearney-digicatapult changed the title npmjs version 0.24.0 contains code that is no longer in this repository npmjs version 0.24.0 is not the version contained in this repository Jan 6, 2025
@sanketshevkar
Copy link
Member

This is weird. @mttrbrts @dselman have y'all seen this before? Also the import statements are var declarations instead of const. Can this be pointing towards some old release of cicero-core?

@rmlearney-digicatapult
Copy link
Author

@mttrbrts @dselman are you able to re-publish on npm?

@sanketshevkar
Copy link
Member

Yeah we haven't cut a release in a long time. @mttrbrts should we cut a release from the latest main? Is this stable enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants