Skip to content

Commit b0b2ff2

Browse files
committed
Fix parallel running for multiple experiments
1 parent 8844926 commit b0b2ff2

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

src/Services/ExperimentsParallelRun/ParallelRunner.php

+4-10
Original file line numberDiff line numberDiff line change
@@ -16,11 +16,6 @@ class ParallelRunner
1616
*/
1717
private $experimentBranchesCacheRepository;
1818

19-
/**
20-
* @var ExperimentRunner
21-
*/
22-
private $experimentRunner;
23-
2419
/**
2520
* @var ParallelRunConfigAccessor
2621
*/
@@ -35,13 +30,11 @@ class ParallelRunner
3530

3631
public function __construct(
3732
ExperimentBranchesCacheRepository $experimentBranchesCacheRepository,
38-
ExperimentRunner $experimentRunner,
3933
ParallelRunConfigAccessor $parallelRunConfig,
4034
Cacher $cacher,
4135
RelatedUserBranchDetector $relatedUserBranchDetector
4236
) {
4337
$this->experimentBranchesCacheRepository = $experimentBranchesCacheRepository;
44-
$this->experimentRunner = $experimentRunner;
4538
$this->parallelRunConfigAccessor = $parallelRunConfig;
4639
$this->cacher = $cacher;
4740
$this->relatedUsersBranchDetector = $relatedUserBranchDetector;
@@ -54,15 +47,16 @@ public function run(string $userSignature, string $experimentAlias): ExperimentR
5447
return $experimentRunResult;
5548
}
5649

57-
$runFunction = function () use ($experimentAlias, $userSignature) {
50+
$experimentRunner = new ExperimentRunner();
51+
$runFunction = function () use ($experimentAlias, $userSignature, $experimentRunner) {
5852
$branches = $this
5953
->experimentBranchesCacheRepository
6054
->getByExperimentAlias($experimentAlias);
6155

6256
foreach ($branches->getExperimentBranches() as $branch) {
63-
$this->experimentRunner->addSide($branch->getUid(), (float)$branch->getPercentage());
57+
$experimentRunner->addSide($branch->getUid(), (float)$branch->getPercentage());
6458
}
65-
$branch = $this->experimentRunner->roll();
59+
$branch = $experimentRunner->roll();
6660

6761
$task = new AddUserToBranchTask(
6862
$experimentAlias,

0 commit comments

Comments
 (0)