@@ -16,11 +16,6 @@ class ParallelRunner
16
16
*/
17
17
private $ experimentBranchesCacheRepository ;
18
18
19
- /**
20
- * @var ExperimentRunner
21
- */
22
- private $ experimentRunner ;
23
-
24
19
/**
25
20
* @var ParallelRunConfigAccessor
26
21
*/
@@ -35,13 +30,11 @@ class ParallelRunner
35
30
36
31
public function __construct (
37
32
ExperimentBranchesCacheRepository $ experimentBranchesCacheRepository ,
38
- ExperimentRunner $ experimentRunner ,
39
33
ParallelRunConfigAccessor $ parallelRunConfig ,
40
34
Cacher $ cacher ,
41
35
RelatedUserBranchDetector $ relatedUserBranchDetector
42
36
) {
43
37
$ this ->experimentBranchesCacheRepository = $ experimentBranchesCacheRepository ;
44
- $ this ->experimentRunner = $ experimentRunner ;
45
38
$ this ->parallelRunConfigAccessor = $ parallelRunConfig ;
46
39
$ this ->cacher = $ cacher ;
47
40
$ this ->relatedUsersBranchDetector = $ relatedUserBranchDetector ;
@@ -54,15 +47,16 @@ public function run(string $userSignature, string $experimentAlias): ExperimentR
54
47
return $ experimentRunResult ;
55
48
}
56
49
57
- $ runFunction = function () use ($ experimentAlias , $ userSignature ) {
50
+ $ experimentRunner = new ExperimentRunner ();
51
+ $ runFunction = function () use ($ experimentAlias , $ userSignature , $ experimentRunner ) {
58
52
$ branches = $ this
59
53
->experimentBranchesCacheRepository
60
54
->getByExperimentAlias ($ experimentAlias );
61
55
62
56
foreach ($ branches ->getExperimentBranches () as $ branch ) {
63
- $ this -> experimentRunner ->addSide ($ branch ->getUid (), (float )$ branch ->getPercentage ());
57
+ $ experimentRunner ->addSide ($ branch ->getUid (), (float )$ branch ->getPercentage ());
64
58
}
65
- $ branch = $ this -> experimentRunner ->roll ();
59
+ $ branch = $ experimentRunner ->roll ();
66
60
67
61
$ task = new AddUserToBranchTask (
68
62
$ experimentAlias ,
0 commit comments